Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Use int64_t instead of long #301

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

skywolf829
Copy link
Contributor

Fixes compilation on Windows as referenced by #293. Uses int64_t instead of long in scan_cub.cu.

Verified working on Windows 11 PC with CUDA 12.4, torch 2.4.1+cu124, and a RTX 4090.

@skywolf829 skywolf829 changed the title Use int64_t instead of long [Bug] | Use int64_t instead of long Oct 2, 2024
@skywolf829 skywolf829 changed the title [Bug] | Use int64_t instead of long Bug fix: Use int64_t instead of long Oct 2, 2024
Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@liruilong940607 liruilong940607 merged commit 57ccfa1 into nerfstudio-project:master Oct 2, 2024
1 check passed
@skywolf829 skywolf829 deleted the windows_fix branch October 2, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants