Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Offline multisig with complex transaction #3291

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

devchenyan
Copy link
Collaborator

@devchenyan devchenyan commented Jan 5, 2025

issue: Magickbase/neuron-public-issues#429

  • multisig
Screen-2025-01-06-004004.mp4
  • Single signatures
Screen-2025-01-26-111156.mp4

@yanguoyu
Copy link
Collaborator

yanguoyu commented Jan 5, 2025

@Danie0918 Is this result expected?

On the other hand, I didn't get the design for this issue.

@Danie0918
Copy link
Collaborator

#3260

This popup is as expected and addresses Neuron's inability to sign transactions with unrecognized lock scripts.

@yanguoyu
Copy link
Collaborator

yanguoyu commented Jan 7, 2025

#3260

This popup is as expected and addresses Neuron's inability to sign transactions with unrecognized lock scripts.

From #3260, if we skip the unknown lock script. Neuron can sing successfully.

@Danie0918 Danie0918 changed the title fix: Offline sign with complex transaction fix: Offline multisig with complex transaction Jan 8, 2025
@devchenyan devchenyan requested a review from silySuper January 11, 2025 13:18
@silySuper
Copy link
Collaborator

silySuper commented Jan 13, 2025

/package
Packaging for test is done in 12739913571. @silySuper

@Keith-CY
Copy link
Collaborator

Keith-CY commented Jan 15, 2025

/package Packaging for test is done in 12739913571. @silySuper

How is this test going?

@silySuper
Copy link
Collaborator

/package Packaging for test is done in 12739913571. @silySuper

How is this test going?

Plan to finish tomorrow.

@silySuper
Copy link
Collaborator

silySuper commented Jan 16, 2025

I have used this json ,brocast fail and does not pop up window.
transaction_duoqian 2.json
Inputs lock is this:

截屏2025-01-16 14 47 50
2025-01-16.14.44.30.mov

main.log

@silySuper
Copy link
Collaborator

silySuper commented Jan 16, 2025

When click Nervos Dao,neuron crash

2025-01-16.15.58.30.mov

main.log
bundled-ckb-lignt-client-testnet.log

@silySuper
Copy link
Collaborator

2025-01-23.11.37.16.mov

throw error when click confirm

@devchenyan
Copy link
Collaborator Author

devchenyan commented Jan 23, 2025

/package
Packaging for test is done in 12923366764. @devchenyan

@silySuper
Copy link
Collaborator

Approve flow is abnormal,in expect,export transaction->sign &&export transaction ->broadcast->pop up transaction hash tip,but actual is export transaction->sign &&export transaction->sign &&export transaction(now pop up error also)->broadcast

here is actual affect video:

2025-01-23.15.43.46.mov

@devchenyan
Copy link
Collaborator Author

Approve flow is abnormal,in expect,export transaction->sign &&export transaction ->broadcast->pop up transaction hash tip,but actual is export transaction->sign &&export transaction->sign &&export transaction(now pop up error also)->broadcast

here is actual affect video:

2025-01-23.15.43.46.mov

The purpose of this requirement is to skip unrecognized inputs and only sign the recognizable ones. However, it does not guarantee that the signed transaction can be successfully broadcast.

@Danie0918 please confirm.

@Danie0918
Copy link
Collaborator

Approve flow is abnormal,in expect,export transaction->sign &&export transaction ->broadcast->pop up transaction hash tip,but actual is export transaction->sign &&export transaction->sign &&export transaction(now pop up error also)->broadcast
here is actual affect video:
2025-01-23.15.43.46.mov

The purpose of this requirement is to skip unrecognized inputs and only sign the recognizable ones. However, it does not guarantee that the signed transaction can be successfully broadcast.

@Danie0918 please confirm.

It's okay.

@Danie0918
Copy link
Collaborator

Single signatures also need to support this feature.

@devchenyan
Copy link
Collaborator Author

Single signatures also need to support this feature.

supported

@Danie0918 Danie0918 requested review from yanguoyu and homura January 26, 2025 02:10
@Danie0918
Copy link
Collaborator

@yanguoyu @homura Please have a review.

@silySuper
Copy link
Collaborator

截屏2025-01-26 10 41 09 ignore spell wrong

@devchenyan
Copy link
Collaborator Author

截屏2025-01-26 10 41 09 ignore spell wrong

fixed
image

@silySuper
Copy link
Collaborator

silySuper commented Jan 26, 2025

/package
Packaging for test is done in 12972622182. @silySuper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants