-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Offline multisig with complex transaction #3291
base: develop
Are you sure you want to change the base?
Conversation
@Danie0918 Is this result expected? On the other hand, I didn't get the design for this issue. |
This popup is as expected and addresses Neuron's inability to sign transactions with unrecognized lock scripts. |
/package |
How is this test going? |
Plan to finish tomorrow. |
I have used this json ,brocast fail and does not pop up window. 2025-01-16.14.44.30.mov |
When click Nervos Dao,neuron crash 2025-01-16.15.58.30.mov |
2025-01-23.11.37.16.movthrow error when click confirm |
/package |
Approve flow is abnormal,in expect,export transaction->sign &&export transaction ->broadcast->pop up transaction hash tip,but actual is export transaction->sign &&export transaction->sign &&export transaction(now pop up error also)->broadcast here is actual affect video: 2025-01-23.15.43.46.mov |
The purpose of this requirement is to skip unrecognized inputs and only sign the recognizable ones. However, it does not guarantee that the signed transaction can be successfully broadcast. @Danie0918 please confirm. |
It's okay. |
Single signatures also need to support this feature. |
supported |
/package |
issue: Magickbase/neuron-public-issues#429
Screen-2025-01-06-004004.mp4
Screen-2025-01-26-111156.mp4