Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't handle subscribe message until we change the API to secure it #2

Closed
wants to merge 2 commits into from

Conversation

vincentfretin
Copy link
Member

Don't handle subscribe message until we change the API to secure it with JWT.
This API is not used currently by naf-janus-adapter, but this can still be used for eavesdropping if the UserId of a participant in a room can be easily known (not a random clientId), see my example mozilla#81 (comment)

This is a temporary PR for those using JWT to secure their rooms. I won't merge this.
I'll close this PR once I work on:

@vincentfretin vincentfretin mentioned this pull request Feb 19, 2022
@vincentfretin
Copy link
Member Author

I actually merged that in master. I'll revert the commit on master and enable again the subscribe message with proper security when I'll have the use case for it.

@vincentfretin vincentfretin deleted the disable-subscribe-message branch October 26, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant