Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db_schema: system_info.system_name -> system_name #434

Merged
merged 1 commit into from
Oct 19, 2022
Merged

db_schema: system_info.system_name -> system_name #434

merged 1 commit into from
Oct 19, 2022

Conversation

lyuyangh
Copy link
Member

part of #433 - Step 1: Move fields out of System.system_info

  • This PR moves system_info.system_name -> system_name. I won't delete system_info.system_name from the DB just yet though. I only removed the code that depends on it.
  • DB migration is required. I plan to run the migration on the original collection because the operation is simple. This is tested on dev. I will run the migration script on the production DB when this PR is merged.

@lyuyangh lyuyangh requested a review from neubig as a code owner October 18, 2022 19:28
@lyuyangh lyuyangh mentioned this pull request Oct 18, 2022
Merged
@lyuyangh lyuyangh merged commit 45d6c9b into main Oct 19, 2022
@lyuyangh lyuyangh deleted the caching branch October 19, 2022 00:41
@lyuyangh lyuyangh mentioned this pull request Oct 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neubig neubig neubig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyuyangh @neubig