SystemModel: update_overall_statistics() cache invalidation and refactoring #491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #433
update_overall_statistics()
is called multiple times. This method can actually be called multiple times now. (fixes remaining issues from implement update_overall_statistics() and refactor create_system #483 )update_overall_statistics._process()
relies onmetadata
. This does not work becausemetadata
is only available when the system is submitted (metadata
is not available when we callupdate_overall_statistics()
to update the cache). This PR is a first attempt to remove the dependency onmetadata
. To remove the dependency completely, some additional fields need to be stored in the DB. I will follow up with another PR to handle those fields.get_private_properties()
now raises aValueError
if the system doesn't exist instead of aborting. If the system doesn't exist when this method is called, it indicates a misuse of the method so anException
is more appropriate.Compatibility
explainaboard_client
shouldn't be affected.