Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] read value description from user dictionary correctly #623

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Nov 10, 2023

A couple of things I noticed while working on this:

  1. If we mock store data incorrectly, i.e. not how it actually looks at runtime, then the tests pass but the app is still broken
  2. It's really not very easy to get a quick sense of where information is kept in the store or what it would look like at runtime. The dev tools help, but it's still tricky to understand how a value ended up looking the way it does
  3. Our e2e should help catch this but they are really hard to edit / change, so it's often easier to test manually - that's not good

Changes proposed in this pull request:

  • fix store getter for value descriptions
  • fix mocked data in unit test for getter

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit 7216048
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/65522bb37f6e470008057634
😎 Deploy Preview https://deploy-preview-623--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs marked this pull request as ready for review November 10, 2023 18:26
@rmanaem rmanaem self-requested a review November 12, 2023 20:39
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

store/index.js Show resolved Hide resolved
@surchs surchs merged commit 3cf91bf into main Nov 13, 2023
8 checks passed
@surchs surchs deleted the surchs/issue616 branch November 13, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descriptions for discrete values are not shown in the annotation workflow
2 participants