Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the condition for fail case nodes_response_status from federation API #125

Closed
3 tasks done
rmanaem opened this issue Apr 12, 2024 · 1 comment · Fixed by #126
Closed
3 tasks done

Fix the condition for fail case nodes_response_status from federation API #125

rmanaem opened this issue Apr 12, 2024 · 1 comment · Fixed by #126
Assignees
@rmanaem
Labels
released This issue/pull request has been released.

Comments

@rmanaem
Copy link
Contributor

rmanaem commented Apr 12, 2024 •
edited
Loading

federation API returns fail not failure when all queried nodes fail.

To address we need to:

  • Update ResultContainer
  • Update mock responses
  • Update App
@rmanaem rmanaem moved this to Implement - Active in Neurobagel Apr 12, 2024
@rmanaem rmanaem self-assigned this Apr 12, 2024
@rmanaem rmanaem changed the title Fix the condition for fail nodes_response_status from federation API Fix the condition for fail case nodes_response_status from federation API Apr 12, 2024
@rmanaem rmanaem mentioned this issue Apr 12, 2024
Merged
7 tasks
@rmanaem rmanaem moved this from Implement - Active to Implement - Done in Neurobagel Apr 12, 2024
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Apr 12, 2024
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Apr 15, 2024
@surchs
Copy link
Contributor

surchs commented Apr 15, 2024

🚀 Issue was released in v0.2.1 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmanaem rmanaem

Labels
released This issue/pull request has been released.
Projects
Neurobagel
Archived in project
Milestone
No milestone
2 participants
@surchs @rmanaem