[FIX] Fixed the condition for when federation API's nodes_response_status is fail

[rmanaem]

• Closes Fix the condition for fail case nodes_response_status from federation API #125

Checklist

This section is for the PR reviewer

• PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
• PR has a label for the release changelog or skip-release (to be applied by maintainers only)
• PR links to GitHub issue with mention Closes #XXXX
• Tests pass
• Checks pass

For new features:

• Tests have been added

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

[netlify]

✅ Deploy Preview for neurobagel-query ready!

Name	Link
🔨 Latest commit	d014167
🔍 Latest deploy log	https://app.netlify.com/sites/neurobagel-query/deploys/661d514c13c7d40008425879
😎 Deploy Preview	https://deploy-preview-126--neurobagel-query.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[surchs]

Thanks @rmanaem , this addressed the issue and looks good. I think we don't have to add a specific regression test here because of I had used the correct response body in the mocks the tests would have already failed, right?

If they would not have failed, then let's add a test to check that the error is handled correctly.

Otherwise 🧑‍🍳

[rmanaem]

this addressed the issue and looks good. I think we don't have to add a specific regression test here because of I had used the correct response body in the mocks the tests would have already failed, right?

Correct.

[surchs]

🚀 PR was released in v0.2.1 🚀