Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the participants-results table nice for humans and machines #356

Closed
6 of 8 tasks
surchs opened this issue Nov 12, 2024 · 4 comments · Fixed by #357
Closed
6 of 8 tasks

make the participants-results table nice for humans and machines #356

surchs opened this issue Nov 12, 2024 · 4 comments · Fixed by #357
Assignees
Labels
refactor Simplifying or restructuring existing code or documentation. released This issue/pull request has been released.

Comments

@surchs
Copy link
Contributor

surchs commented Nov 12, 2024

The query tool let's you download information about cohorts you find. We have two kinds of users in mind for this information:

  1. human users, who likely want to look at the downloaded information to learn more about their cohort
  2. machines or tools who want to use the information to provide services to their own users, e.g. to download a cohort to the users computer (or create symlinks Create script for accessing cohort query matches on BIC planning#188)

Right now our downloadable files do a little bit of both, and neither very nicely (e.g. include many fully expanded IRIs etc). We mainly want to make sure that

  • there is one file that includes information about the cohort in a nice-for-humans format
  • there is another file that includes enough information for tools like cohort-creator to keep doing what they are doing

And to achieve this, we are willing to have a bit of duplication in these files.

Here is a draft of both formats for us to discuss: https://docs.google.com/spreadsheets/d/1rLgbzZv1AqgYTGglI3yuQVdOM1bbYvvY8ijmbTXsfHg/edit?usp=sharing

TODO

  • Discuss and agree on a first format for the human and machine readable files
  • Pick an intuitive name for both files
  • Implement the new file formats in the query tool
  • Update the query tool examples in neurobagel/examples (discuss / decide what to do with the old examples)
  • Ping Remi in cohort-creator land about the upcoming change to the format of these files
  • Deploy / Release the new query tool version
@surchs surchs moved this to Backlog in Neurobagel Nov 15, 2024
@surchs surchs self-assigned this Nov 15, 2024
@surchs surchs moved this from Backlog to Implement - Active in Neurobagel Nov 15, 2024
@surchs surchs changed the title Discuss how to make the participants-results table nice make the participants-results table nice for humans and machines Nov 15, 2024
@rmanaem rmanaem self-assigned this Nov 15, 2024
@surchs surchs removed their assignment Nov 15, 2024
@rmanaem rmanaem added the refactor Simplifying or restructuring existing code or documentation. label Nov 15, 2024
@alyssadai
Copy link
Contributor

One more thought: how about changing the current column name SessionFilePath to SessionPath, to better reflect what the path points to?

@surchs
Copy link
Contributor Author

surchs commented Nov 15, 2024

I believe we previously used SessionPath. It seems like a better name to me as well, but before we switch it again, we should look up what the previous switch reason was

@surchs
Copy link
Contributor Author

surchs commented Nov 16, 2024

The change from SessionPath to SessionFilePath came in #112, but I don't see a reason given. So let's make sure that if we change the name now, we list our reason clearly in the PR

@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Nov 21, 2024
Copy link
Contributor

🚀 Issue was released in v0.7.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Simplifying or restructuring existing code or documentation. released This issue/pull request has been released.
Projects
Status: Review - Done
Development

Successfully merging a pull request may close this issue.

3 participants