Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Handle parsing of diagnosis and assessment tool options coming from a node api #224

Closed
wants to merge 5 commits into from

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Jul 24, 2024

Changes proposed in this pull request:

  • Fixed the warning for default props
  • Implemented a condition to handle attribute options coming from node api

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 19ec9ef
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/66a1433505027b0008661379
😎 Deploy Preview https://deploy-preview-224--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem added the pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) label Jul 24, 2024
@rmanaem rmanaem closed this Aug 2, 2024
@rmanaem rmanaem deleted the bug-223 branch December 12, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query tool unable to parse diagnosis and assessment tool options coming from a node API
1 participant