-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Implemented component tests #31
Conversation
Added cypress screenshots and downloads directories
when healthy control checkbox is checked
✅ Deploy Preview for neurobagel-query ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmanaem for this big PR, and for putting us back on trusted ground with the tests! Tried the tests locally, all runs great (and super fast now 🎉), very nice
I left some comments for clarity and some separation of concern. Take a look, and see what you think. I think we can fix some of those over time because they don't affect the tests diretly.
🧑🍳
Added an assertion for the `Mui-error` class on the helper text
🚀 PR was released in |
Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: