Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Implemented component tests #31

Merged
merged 26 commits into from
Feb 26, 2024
Merged

[MNT] Implemented component tests #31

merged 26 commits into from
Feb 26, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Feb 21, 2024

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-tests Add or improve existing tests label Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit c312006
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65dcaea5eb7edf00089a52aa
😎 Deploy Preview https://deploy-preview-31--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Feb 21, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@surchs surchs self-requested a review February 22, 2024 06:39
@rmanaem rmanaem changed the title Implemented component tests [MNT] Implemented component tests Feb 22, 2024
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmanaem for this big PR, and for putting us back on trusted ground with the tests! Tried the tests locally, all runs great (and super fast now 🎉), very nice

I left some comments for clarity and some separation of concern. Take a look, and see what you think. I think we can fix some of those over time because they don't affect the tests diretly.

🧑‍🍳

.github/workflows/component-test.yaml Show resolved Hide resolved
cypress/component/CategoricalField.cy.tsx Outdated Show resolved Hide resolved
cypress/component/ContinuousField.cy.tsx Outdated Show resolved Hide resolved
cypress/component/ContinuousField.cy.tsx Outdated Show resolved Hide resolved
cypress/component/ContinuousField.cy.tsx Outdated Show resolved Hide resolved
cypress/component/ResultContainer.cy.tsx Show resolved Hide resolved
cypress/component/ResultContainer.cy.tsx Show resolved Hide resolved
cypress/component/ResultContainer.cy.tsx Show resolved Hide resolved
cypress/e2e/Form.cy.ts Outdated Show resolved Hide resolved
src/components/NBDialog.tsx Show resolved Hide resolved
Added an assertion for the `Mui-error` class on the helper text
@rmanaem rmanaem merged commit 6832b89 into main Feb 26, 2024
7 checks passed
@rmanaem rmanaem deleted the maint-20 branch February 26, 2024 15:33
@surchs
Copy link
Contributor

surchs commented Mar 7, 2024

🚀 PR was released in v0.1.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-tests Add or improve existing tests released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

component tests
2 participants