-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Standardized query result files #398
Conversation
Reviewer's Guide by SourceryThis PR standardizes the query result files by consolidating the logic for both human-readable and machine-readable formats into a single code path. The changes reorganize the column order in the TSV output and introduce conditional formatting based on the file type. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmanaem - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please document the rationale for reordering the columns in the TSV output, as this represents a breaking change that could affect downstream tools.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
✅ Deploy Preview for neurobagel-query ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmanaem 🎉 !
Take a look at the space-separated arrays. My memory is that we wanted there to be no spaces (in both the human and machine files) between array elements (e.g. [T1Weighted,FlowWeighted]
instead of [T1Weighted, FlowWeighted]
🧑🍳
* Standardized query result files * Addressed the PR review comments
* Implemented splitbutton for `DownloadResultButton` * Updated `GetDataDialog` component * Updated `ResultContainer` component * Updated `ResultsTSV` e2e test * Updated docker command * [ENH] Standardized query result files (#398) * Standardized query result files * Addressed the PR review comments * Addressed PR review comments
🚀 PR was released in |
query-tool-results
files neurobagel_examples#47NOTE: If this pull request is to be released, the release label must be applied once the review process is done to avoid the local and remote from going out of sync as a consequence of the
bump version
workflow runChecklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
query-tool-results
files in the neurobagel_examples repo have been regeneratedFor new features:
For bug fixes:
Summary by Sourcery
Standardize the format of query result files to ensure consistency across different datasets and scenarios, and update tests to validate the new format.
Enhancements:
Tests: