Ports the graph tracing to torch.fx #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanokin
reviewed
Dec 16, 2024
| appear with the qualified name ``foo.bar.baz`` here. | ||
| """ | ||
| # Tests that the module is in the list of custom leaves | ||
| if self.custom_leaf_modules and isinstance(m, self.custom_leaf_modules): |
There was a problem hiding this comment.
Do we need to check for torch.nn.Sequential here?
| nodes = {} | ||
| edges = [] | ||
| ignored_nodes = set() | ||
| skipped_nodes = set() |
There was a problem hiding this comment.
Does skipped_nodes means nodes we still need to process?
| continue | ||
| elif node.op == "output": | ||
| nodes[str(node.name)] = nir.Output(np.array([1])) | ||
| elif node.op == "call_function": |
There was a problem hiding this comment.
Should we add a check for other non-allowed functions (multiplies or divisions) and add an exception?
| assert len(_filter_edges(graph, nir.Affine, nir.Output)) == 1 | ||
|
|
||
|
|
||
| def test_trace_addition(): |
There was a problem hiding this comment.
how about substraction? does that work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the graph tracing to torch.fx instead of using the homebrewed graph tracer.
TBC...