Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefillableSolution: selective transfer outwards #2583

Merged

Conversation

whatston3
Copy link
Contributor

About the PR

Adds a field to RefillableSolutionComponent to disable outward transfer.
Removes nutriment from compressed cubes, but keeps them transferrable (they should probably also be injectable at this point but I've left that as-is)

Why / Balance

Quasi-hacky fix for space-wizards/space-station-14#33115.

Pizza sanctity.

Soup should probably be an exception, but a differentiated SoupBase vs. FoodBowlBase would also be useful here.

How to test

  1. Drag a pizza onto a ChemMaster, nothing happens.
  2. Pour lime juice onto a monkey cube, drag it into the ChemMaster, 1u of lime juice comes out.
  3. Spawn a mop, spawn a water bottle, and something to make a puddle. Mop up the water, mop up the puddle, spawn a sausage bread. Wring out the mop into the sausage bread. The not-water should be transferred. Bone apple teeth.
  4. Spawn a drain, try to drain the soggy sausage bread, nothing should happen.

Media

Just like mama used to make.
image

Requirements

Breaking changes

Changelog

🆑

  • fix: Reagents in food solutions cannot be transferred out, e.g. into a ChemMaster.

@dvir001
Copy link
Contributor

dvir001 commented Dec 17, 2024

Are you cool if anyone want to MIT this to upstream?

@whatston3
Copy link
Contributor Author

Are you cool if anyone want to MIT this to upstream?

For sure. Still, I'm reluctant to even put it up there because it's still a janky fix as-is. Better separation of components would be better.

@dvir001 dvir001 self-requested a review December 20, 2024 22:45
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Dec 20, 2024
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine

image

@dvir001 dvir001 merged commit 59714ea into new-frontiers-14:master Dec 20, 2024
13 checks passed
FrontierATC added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# S: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants