-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RefillableSolution: selective transfer outwards #2583
Merged
dvir001
merged 8 commits into
new-frontiers-14:master
from
whatston3:2024-12-17-selectively-refillable
Dec 20, 2024
Merged
RefillableSolution: selective transfer outwards #2583
dvir001
merged 8 commits into
new-frontiers-14:master
from
whatston3:2024-12-17-selectively-refillable
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are you cool if anyone want to MIT this to upstream? |
For sure. Still, I'm reluctant to even put it up there because it's still a janky fix as-is. Better separation of components would be better. |
dvir001
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FrontierATC
added a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds a field to RefillableSolutionComponent to disable outward transfer.
Removes nutriment from compressed cubes, but keeps them transferrable (they should probably also be injectable at this point but I've left that as-is)
Why / Balance
Quasi-hacky fix for space-wizards/space-station-14#33115.
Pizza sanctity.
Soup should probably be an exception, but a differentiated SoupBase vs. FoodBowlBase would also be useful here.
How to test
Media
Just like mama used to make.
Requirements
Breaking changes
Changelog
🆑