Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the NFSD Uplink offerings for consistency #2589

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

Jakumba
Copy link
Contributor

@Jakumba Jakumba commented Dec 19, 2024

About the PR

  • Added rubber .35 auto pistol magazines to all NFSD uplinks
  • Added rubber .20 rifle magazines to all NFSD command uplinks
  • Added the WT550 to the Bailiff's uplink
  • Added WT550 top-loaded magazines to the Bailiffs uplink
  • Added Vulcan to all NFSD command uplinks
  • Added .30 rifle magazines to all NFSD command uplinks
  • Added .30 rifle rubber magazines to all NFSD command uplinks
  • Added the Vulcan to the lethal stock crate
  • Removed the Inspector from the lethal stock crate
  • Added the Vulcan to the non-lethal stock crate, with rubber magazines preloaded
  • Added the Energy gun to the non-lethal stock crate
  • Added the Energy gun to the Bailiffs uplink
  • Removed the Kammerer from the NFSD command uplink
  • Removed the Deckard from the NFSD command uplink
  • Removed the n1984 from the NFSD command uplink

Why / Balance

  • The NFSD has a difficult time acquiring rubber magazines for their long arms, hopefully this addresses it and encourages better quality play from the NFSD in general, and makes adhereing to escalation rules (and de-escalating) easier.
  • Alleviates the requirement for the NFSD to salvage purely to produce rubber magazines.
  • The Bailiff already has access to both the WT550 and Energy Gun via the Lethal Armoury Stock Crate, it feels counter intuitative that they cannot purchase these items individually.
  • Added the Vulcan to the NFSD armoury by @dvir001's request
  • Added less-lethal variant of the Vulcan to the NFSD armoury too!
  • Removed quasi-civilian/syndicate weapons (Kammerer, Deckard, n1984) from the NFSD uplink.

How to test

  1. Spawn as Bailiff
  2. Check that .20, .30 and .35 auto magazine boxes are available to purchase
  3. Purchase one of each, check they actually contain rubber filled magazines
  4. Check the energy gun is available for purchase
  5. Check the WT550 and its' magazines are available for purchase
  6. Check the Vulcan is available for purchase
  7. Check the Kammerer, Deckard and n1984 are no longer available for purchase
  8. Purchase a lethal & non-lethal crate
  9. Check the lethal crate no longer contains Inspectors, but has 4 Vulcans
  10. Check the non-lethal crate has 4 Vulcans and 4 Energy guns

Media

2024-12-18 23_59_37-Window

Requirements

Breaking changes

  • Hopefully none!

Changelog

🆑

  • Added rubber .35 auto pistol magazines to all NFSD uplinks
  • Added rubber .20 rifle magazines to all NFSD command uplinks
  • Added the WT550 to the Bailiff's uplink
  • Added WT550 top-loaded magazines to the Bailiffs uplink
  • Added Vulcan to all NFSD command uplinks
  • Added .30 rifle magazines to all NFSD command uplinks
  • Added .30 rifle rubber magazines to all NFSD command uplinks
  • Added the Vulcan to the lethal stock crate
  • Removed the Inspector from the lethal stock crate
  • Added the Vulcan to the non-lethal stock crate, with rubber magazines preloaded
  • Added the Energy gun to the non-lethal stock crate
  • Added the Energy gun to the Bailiffs uplink
  • Removed the Kammerer from the NFSD command uplink
  • Removed the Deckard from the NFSD command uplink
  • Removed the n1984 from the NFSD command uplink

@Danchi299
Copy link

can we also get 45 Magnum Magazines (not speedloaders) in uplink for the N1984 Pistol?

@Jakumba
Copy link
Contributor Author

Jakumba commented Dec 24, 2024

can we also get 45 Magnum Magazines (not speedloaders) in uplink for the N1984 Pistol?

Yeah feels like an oversight on my part, I'll add them when I get a chance before this is reviewed.

@dvir001
Copy link
Contributor

dvir001 commented Dec 27, 2024

Going to mark this PR on hold till we get the DeltaV guns added.

@Jakumba
Copy link
Contributor Author

Jakumba commented Jan 19, 2025

Now we've got the Delta-V guns added, is there anything additional we should do with this PR?

@dvir001
Copy link
Contributor

dvir001 commented Jan 19, 2025

Now we've got the Delta-V guns added, is there anything additional we should do with this PR?

Yes I almost forgot to comment here, please use the DeltaV guns to replace the syndicate ones from here, and have the high tier DeltaV security ones as offerings here.

@dvir001 dvir001 added S: Needs Review This PR is awaiting reviews and removed S: DO NOT MERGE labels Jan 19, 2025
@Cheackraze Cheackraze merged commit 44e3cdd into new-frontiers-14:master Jan 21, 2025
13 checks passed
FrontierATC added a commit that referenced this pull request Jan 21, 2025
@Jakumba Jakumba deleted the nfsd-uplink-store-rubbers branch January 21, 2025 10:42
@dvir001
Copy link
Contributor

dvir001 commented Jan 21, 2025

That fucking changelog need another PR just to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FTL No C# S: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants