Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a fistful of plushies #2591

Merged
merged 6 commits into from
Dec 21, 2024
Merged

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Dec 20, 2024

About the PR

This PR adds a pair of plushie sprites created by adjusts reading glasses Lvl 1 Eevee (Myst/Yani Kali). Who, despite having a befuddling name, appeared to make some rather nice sprites but was asking for a hand in bringing them across the finish line.

This PR adds them to the general state of existence. The plushie vend, the mail inventory and that weird ticket thing.

Hopefully these aren't, like, some kind of secret homages to some specific players. I'm just shoveling yaml here I don't know nuthin.

Why / Balance

Seems nice.

How to test

Honestly check the mail piece. I mighta dropped the ball there. Not sure.

Media

ss+(2024-12-19+at+06 45 58)

Requirements

Breaking changes

¯\_(ツ)_/¯

Changelog

🆑

  • add: Adds a pair of plushies from Lvl 1 Eevee

Copy link
Contributor

github-actions bot commented Dec 20, 2024

RSI Diff Bot; head commit be4025f merging into 554cedb
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Fun/toys.rsi

State Old New Status
plushie_mailvulp Added
plushie_yarrmoth Added

Edit: diff updated after be4025f

@dvir001 dvir001 self-requested a review December 20, 2024 17:37
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Dec 20, 2024
@dvir001
Copy link
Contributor

dvir001 commented Dec 20, 2024

Sure

image

@dvir001
Copy link
Contributor

dvir001 commented Dec 20, 2024

Moved the mail spawn to be more rare to match janitor and jester

@dvir001
Copy link
Contributor

dvir001 commented Dec 20, 2024

Same with the emag tier

We should also probably add spawn to wreck at some point for all plusie

@dustylens
Copy link
Contributor Author

For my own clarification and for that of people referencing this PR in the future to include their own things could you explain when a plushie should or should not be an emag entry?

@dvir001
Copy link
Contributor

dvir001 commented Dec 21, 2024

For my own clarification and for that of people referencing this PR in the future to include their own things could you explain when a plushie should or should not be an emag entry?

If its based on a real player it should go into emag, anything general is general.

@dustylens
Copy link
Contributor Author

dustylens commented Dec 21, 2024

Just waiting on dvir to re-post the reasoning for locking plushies behind the emag for future generations. Otherwise the changes appear to be good and fine to me.

Also: Done to avoid having players plushies all available on round start so its less meta'ish to get get them around, also it makes them more unique when they do show up

@dvir001 dvir001 merged commit 878bda0 into new-frontiers-14:master Dec 21, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants