Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mercfab recipes #2639

Closed

Conversation

blackknight954
Copy link
Contributor

@blackknight954 blackknight954 commented Dec 30, 2024

About the PR

Allows the mercfab to print Arsenal equipment.

Why / Balance

With the exception of ship guns, more specifically the grenade launchers, most Arsenal tech does not have enough destructive power in space to warrant gating it to only NFSD.

How to test

Load a server
Spawn a Mercfab, observe the rubber rounds
Do some arsenal research, observe the arsenal tech added to the fab.

Media

Incendiary and uraniuum munitions
image

Requirements

Breaking changes

Nothing I can see.
Changelog
🆑

  • The Mercfab is able to print arsenal technology, excluding ship guns and grenade launcher shells.

@dvir001
Copy link
Contributor

dvir001 commented Dec 30, 2024

Uranium and Incendiary ammo are power creep used in upsteam to fight nukies, I will avoid giving them in printing as they break balance for AI and PVP / PVE

Tranquilizer is busted still

@blackknight954
Copy link
Contributor Author

Tranquilizer is busted still

Is it? I've tested shooting 4 shells at NPC's and they yawn but they don't sleep in most cases

@blackknight954 blackknight954 marked this pull request as ready for review January 1, 2025 20:13
@blackknight954 blackknight954 marked this pull request as draft January 1, 2025 21:00
@blackknight954 blackknight954 marked this pull request as ready for review January 7, 2025 06:55
Copy link
Contributor

@GreaseMonk GreaseMonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restart the PR on a new branch having only 1 commit and one file change preferably, currently it says 20 commits 1 file change. if this isn't a github screw-up, something is not right with this PR.

image

@blackknight954
Copy link
Contributor Author

@GreaseMonk

Sorry for the delay

New PR can be found here:
#2677

@blackknight954 blackknight954 deleted the MercfabRecipes branch January 11, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants