Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silcon players no longer get deleted with grids #2680

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 11, 2025

About the PR

BorgChassis is now safe as long as its player controlled.

Why / Balance

Machine life forms

How to test

Open 2 clients, mob a player controlled borg on wreck, delete the werck and see borg player get to live.

Media

N/A

Requirements

Breaking changes

N/A

Changelog
🆑

  • fix: Player controlled borgs no longer get deleted on event grids when they end.

@github-actions github-actions bot added C# S: Needs Review This PR is awaiting reviews labels Jan 11, 2025
@whatston3
Copy link
Contributor

whatston3 commented Jan 11, 2025

Works well. Spawned a cyborg, took control of it, and another that isn't controlled on a dungeon. Ended the rule, I wasn't destroyed (edit: but the uncontrolled one was)

@whatston3 whatston3 merged commit 6f85da4 into new-frontiers-14:master Jan 11, 2025
11 checks passed
FrontierATC added a commit that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# S: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants