Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini station anchor #2706

Merged
merged 11 commits into from
Jan 18, 2025
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 15, 2025

About the PR

I love me ancor, smaller one mean we can properly map it on ships and on POI.

Why / Balance

Mini gravity, mini anchor.

How to test

Spawn it, use it

Media

I downscale it to 1 tile, its a sin.

Requirements

Breaking changes

Removed the normal one from printing, upstream had a PR to also remove it regardless of our PR so match the goal anyway.

Changelog
🆑

  • add: Added a mini station anchor to the Shuttlecraft tech.

@blackknight954
Copy link
Contributor

Would having it on ships not make it so that theroetically NFSD could just make a "Haha we cant be pushed" ship blockade at a UIV or something? dunno that's the first thing that came to mind

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 15, 2025

Would having it on ships not make it so that theroetically NFSD could just make a "Haha we cant be pushed" ship blockade at a UIV or something? dunno that's the first thing that came to mind

Copilot what an emp?
Not a big issue.

@Houtblokje
Copy link
Contributor

Would having it on ships not make it so that theroetically NFSD could just make a "Haha we cant be pushed" ship blockade at a UIV or something? dunno that's the first thing that came to mind

Yeah so? You can go around it, or just blast it with something. I do feel like the anchor should take a while to disable/enable though, so you can't just use it as "Parking mode +"

@blackknight954
Copy link
Contributor

Would having it on ships not make it so that theroetically NFSD could just make a "Haha we cant be pushed" ship blockade at a UIV or something? dunno that's the first thing that came to mind

Yeah so? You can go around it, or just blast it with something. I do feel like the anchor should take a while to disable/enable though, so you can't just use it as "Parking mode +"

Naw I can just imagine it'd be used to troll somehow is all, ramming ships is pretty common around NFZ's also. we'll see though

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 16, 2025

Would having it on ships not make it so that theroetically NFSD could just make a "Haha we cant be pushed" ship blockade at a UIV or something? dunno that's the first thing that came to mind

Yeah so? You can go around it, or just blast it with something. I do feel like the anchor should take a while to disable/enable though, so you can't just use it as "Parking mode +"

Naw I can just imagine it'd be used to troll somehow is all, ramming ships is pretty common around NFZ's also. we'll see though

New meta

@dvir001 dvir001 requested a review from whatston3 January 16, 2025 15:24
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jan 16, 2025
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced the density of the mini station anchor, should have the same mass as the big one (665 density w/ 0.64 m^2 fixture area vs. 2.24 m^2 w/ 190 density).

Seems functional. Happy to put a new sprite in later.

Edit: Also, for what it's worth, I don't think the off variants are actually working properly. They seem to start on.

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 16, 2025

Reduced the density of the mini station anchor, should have the same mass as the big one (665 density w/ 0.64 m^2 fixture area vs. 2.24 m^2 w/ 190 density).

Seems functional. Happy to put a new sprite in later.

Edit: Also, for what it's worth, I don't think the off variants are actually working properly. They seem to start on.

The off version is a lie, ship it.

@dvir001 dvir001 requested a review from whatston3 January 16, 2025 22:49
whatston3
whatston3 previously approved these changes Jan 16, 2025
@dvir001 dvir001 dismissed whatston3’s stale review January 16, 2025 23:19

Why is this so fucking broken

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 16, 2025

Good to go but I cant do shit to approve it so its someone else issue now.

@GreaseMonk GreaseMonk merged commit 405e1f4 into new-frontiers-14:master Jan 18, 2025
13 checks passed
FrontierATC added a commit that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# S: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants