Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize "NFSD" in names and descriptions, deputy badge in PTech. #2708

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

whatston3
Copy link
Contributor

About the PR

All instances I could find of "nfsd" or "new frontier sheriff's department" in names or descriptions have been properly capitalized. A few instances of "daw" and "lvhi" were capitalized. A few grammatical errors were fixed.

Renamed the "nfsdlite" to "tac-lite" to avoid the capitalization issue there. Couldn't find any commercially available products under the name.

Also adds the missing deputy badge to the NFSD PTech.

This does not address use of "NFSD" vs "the NFSD", or the use of "New Frontier" vs. "New Frontiers". It gets worse the more you look at it.

Why / Balance

Drivin' me nuts.

How to test

Double check the spawn menu for NFSD items.

Media

Pain.
image

Requirements

Breaking changes

Changelog

Not this time.

@dvir001
Copy link
Contributor

dvir001 commented Jan 17, 2025

Sure, fuck it, as long as its consistent

@dvir001 dvir001 self-requested a review January 17, 2025 12:54
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jan 17, 2025
@dvir001 dvir001 merged commit c54b8c0 into new-frontiers-14:master Jan 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FTL Map-Shuttle Map - Shuttle No C# S: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants