Fix 20gb memory usage for magnet code #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvir001
approved these changes
Jan 20, 2025
|
So when're we going back to listinv? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This is a bandaid fix for high memory usage for bags that use the magnet component.
It still happens when u have total, spread out, enough free slots, but this at least reduces the amount of occurrences of it happening.
Why / Balance
Performance fix
How to test
strap on your favorite magnet bag
put a giant load of items around you, fill up the bag, put even more items around you. (about 20+)
lets say you have 2 spaces left in your bag and theres a ton of items around you that each need 4 spaces.
Now, it wont cost you your computer's soul
Media
Requirements
Breaking changes
None
Changelog
Changelog not needed