-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offshore gas mining refactor #2750
offshore gas mining refactor #2750
Conversation
>bait milon into code improvements Thanks for the code review. |
Your skibidi YAML linter aint got the rizz boi, not very sigma. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks fine. There's a few unused files in there that should've been destroyed, and I think the RandomGasDeposit should be separated out from the regular GasDeposit - the client really doesn't need to know about the deposit generation prototypes.
Content.Client/_NF/Atmos/Consoles/AtmosAlarmGaslockEntryContainer.xaml.cs
Outdated
Show resolved
Hide resolved
private void OnExtractorMapInit(Entity<GasDepositExtractorComponent> ent, ref MapInitEvent args) | ||
{ | ||
UpdateAppearance(ent); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on the ChemMaster's generic update function approach?
SubscribeLocalEvent<GasDepositExtractorComponent, MapInitEvent>(SubscribeUpdateAppearance);
...
private void SubscribeUpdateAppearance<T>(Entity<GasDepositExtractorComponent> ent, ref T ev)
{
UpdateAppearance(ent);
}
Content.Server/_NF/Worldgen/Components/Debris/RandomEntityPopulatorComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/_NF/Worldgen/Components/Debris/RandomEntityPopulatorComponent.cs
Show resolved
Hide resolved
Content.Shared/_NF/Atmos/Components/RandomGasDepositComponent.cs
Outdated
Show resolved
Hide resolved
Fixed issues with the inward/outward appearance not being used, unanchored the portable gaslock/mining drill by default. Separated out the RandomGasDeposit from the deposit itself. Looks good to me. |
Changes look good to me. |
About the PR
refactor of #2403
UI cleanup, making comments good, removing frontier comments from frontier files, namespacing everything correctly, using vars rather than specifying the type, entity pattern, predicted examine events and stuff, switched to primary constructors as those are preferred now, etc etc
Why / Balance
How to test
>look at what the original PR does
>still does the same thing
Requirements
Breaking changes
Changelog
no fun