Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuitsStorage & Jetpacks & Brigmedic #486

Closed
wants to merge 0 commits into from

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Oct 26, 2023

About the PR

Removed SuitsStorage locks, added a SuitsStorage for brigmedic
Added security jetpacks for SuitsStorage, added mini jetpack for salvage.
Organized brigmedic files.

Why / Balance

Adding missing stuff.

Technical details

.yml changes

Media

  • this PR does not require an ingame showcase

Breaking changes

brigmedic hardsuit is missing from the lockers, need to be replaced with the new storage SuitStorageBrigmedic.

Changelog
🆑 dvir01

  • fix: All suits storage had the locks fixes

Copy link
Contributor

@PeccNeck PeccNeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the nonexistent prototype and potential merge conflict, I'd say this looks good. I think. May want to take care of those, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the jetpacks are a nice addition, suit storage locking is already taken care of by #476 (now merged). I wouldn't be surprised if this causes a legitimate merge conflict for once...

Resources/Prototypes/Roles/Jobs/Security/brigmedic.yml Outdated Show resolved Hide resolved
@dvir001 dvir001 closed this Oct 27, 2023
@dvir001 dvir001 force-pushed the SuitsStorage-Unlock branch from 0ebf500 to fe81031 Compare October 27, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants