Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic rate limiting for chat messages #625

Merged
merged 3 commits into from
Dec 10, 2023

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Dec 1, 2023

About the PR

Copy of space-wizards/space-station-14#21907

Why / Balance

Stop server chat spam

Technical details

Upstream code.

Media

  • this PR does not require an ingame showcase

Breaking changes

Not that im aware.

Changelog
N/A

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 1, 2023

Need #626 before.

@Cheackraze
Copy link
Member

@dvir001 uh, that PR you needed before this one is now conflicting

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 4, 2023

FML
I won't be around a PC in the next half an hour to fix it

Copy link
Contributor

github-actions bot commented Dec 4, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Dec 4, 2023
@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Dec 4, 2023
@dvir001
Copy link
Contributor Author

dvir001 commented Dec 4, 2023

Did a copy paste on the file that had the issue and it seem that it was just spacing broken.
Its fine now.

@Cheackraze Cheackraze self-requested a review December 10, 2023 17:49
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Dec 10, 2023
@Cheackraze Cheackraze merged commit b9f658d into new-frontiers-14:master Dec 10, 2023
9 of 10 checks passed
@dvir001 dvir001 deleted the 23-11-26-chat-rate-limit branch December 28, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants