Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firehose integration should support firehose #7

Merged
merged 1 commit into from
Nov 20, 2024
Merged

firehose integration should support firehose #7

merged 1 commit into from
Nov 20, 2024

Conversation

hrai-nr
Copy link
Contributor

@hrai-nr hrai-nr commented Nov 19, 2024

This PR will handle following two scenarios:

  1. If user is passing value of parameter StoreNRLicenseKeyInSecretManager as true , the LicenseKey will be stored in secret manager and will be used from there.
  2. There are few parameters which we are using for entity synthesis, if user passes those value as key in common attribute, we will ignore the values passed by user and use those values which are needed for Entity Synthesis.

Testing Done:

  1. Select StoreNRLicenseKeyInSecretManager as true and see if the secret are getting saved in secret manager and then used from there, the logs should flow in new relic in this scenario.
  2. Select StoreNRLicenseKeyInSecretManager as false, create stack, see the delivery stream, it should use API Key for authentication, check if logs are flowing in new relic.
  3. Attribute related testing: Tested by passing attributes which are used for Entity Synthesis, these attributes are not getting overriden.

Ref:
1.https://docs.aws.amazon.com/firehose/latest/dev/secrets-manager-whats-secret.html
5.https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-kinesisfirehose-deliverystream-secretsmanagerconfiguration.html
6.hashicorp/terraform-provider-aws#38210

Copy link

@nr-rkallempudi nr-rkallempudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrai-nr
Is this tested with enabling/disabling secret manager? also what about QC with attribute overriding?

Can you add some tests you have done in PR description

@hrai-nr hrai-nr merged commit 6336cdb into main Nov 20, 2024
4 checks passed
- !Sub '{{resolve:secretsmanager:${NewRelicLogsLicenseKeySecret}:SecretString:LicenseKey}}'
- !Ref LicenseKey
AccessKey: !If [ShouldCreateSecret, !Ref "AWS::NoValue",!Ref LicenseKey]
SecretsManagerConfiguration:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrai-nr if ShouldCreateSecret is false then does it actually create secret manager but kept disabled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, in case ShouldCreateSecret is false, it will use LicenseKey by storing it in the delivery stream.

Copy link
Contributor

@ahegdeNR ahegdeNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants