feat: Add "STRING" to the list of valid metric units in golden metrics schema #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entityBot
approved these changes
Jan 13, 2025
entityBot
approved these changes
Jan 13, 2025
|
|
entityBot
approved these changes
Jan 13, 2025
entityBot
approved these changes
Jan 13, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
otaviocarvalho
added
the
internal review
|
Other changes are blocking this one to proceed: link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
Story : https://new-relic.atlassian.net/browse/NR-328461
Adding CLS to the golden signals and summary signals. As part of this I am adding STRING to golden signals allow list
Checklist
identifierwill be unique and valid.