DEV-5640: Migrate DReason to TypeScript #1694
Draft
+419
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NRE
|
|||||||||||||||||||||||||||||||||||||
| Project |
NRE
|
| Branch Review |
DEV-5640-convert-reason-for-giving-to-typescript
|
| Run status |
|
| Run duration | 04m 00s |
| Commit |
|
| Committer | Chris Klimas |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
184
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/01-donationPage.cy.js • 2 failed tests • Cypress integration tests
| Test | Artifacts | |
|---|---|---|
| User flow: canceling contribution > happy path |
Screenshots
|
|
| User flow: canceling contribution > double-clicking the cancel button |
Screenshots
|
|
Base automatically changed from
DEV-5617-fix-reason-for-giving-validation-error
to
main
January 10, 2025 15:24
nrh-cklimas
force-pushed
the
DEV-5640-convert-reason-for-giving-to-typescript
branch
from
f3846c1 to
2dbab8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out each section even if it's just with "N/A"
Plan? (if this draft/incomplete indicate what you intend to do and how)
Creating review app for design review.
What's this PR do?
Why are we doing this? How does it help us?
Are there detailed, specific, step-by-step testing instructions in the associated ticket?
Did this PR make changes to the user interface that may require changes to the user-facing docs?
Have automated unit tests been added? If not, why?
How should this change be communicated to end users?
Are there any smells or added technical debt to note?
Has this been documented? If so, where?
What are the relevant tickets? Add a link to any relevant ones.
Do any changes need to be made before deployment to production (adding environment variables, for example)? If so, open a ticket and link it to the ticket for this PR and list it here:
Are there next steps? If so, what? Have tickets been opened for them? List next-step tickets here: