DEV-5281 | Fix bug with canceled_at on one-time contributions #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrh-cklimas
approved these changes
Jan 15, 2025
benjaminEwhite
commented
Jan 15, 2025
| @@ -1651,7 +1651,8 @@ def test_canceled_at_date_when_no_subscription(self): | |||
| "canceled_at", | |||
| [None, datetime.datetime.now(datetime.timezone.utc).timestamp()], | |||
| ) | |||
| def test_cancelled_at_date_when_subscription(self, canceled_at, contribution, subscription_factory, mocker): | |||
| def test_canceled_at_date_when_subscription(self, canceled_at, contribution, subscription_factory, mocker): | |||
There was a problem hiding this comment.
This is just changing test name so spelling of 'canceled' is consistent with spelling on method under test.
benjaminEwhite
commented
Jan 15, 2025
| @@ -1651,7 +1651,8 @@ def test_canceled_at_date_when_no_subscription(self): | |||
| "canceled_at", | |||
| [None, datetime.datetime.now(datetime.timezone.utc).timestamp()], | |||
| ) | |||
| def test_cancelled_at_date_when_subscription(self, canceled_at, contribution, subscription_factory, mocker): | |||
| def test_canceled_at_date_when_subscription(self, canceled_at, contribution, subscription_factory, mocker): | |||
| contribution.interval = ContributionInterval.MONTHLY | |||
There was a problem hiding this comment.
We weren't ensuring this was recurring in earlier version of test, and need to do that given conditionality in method now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out each section even if it's just with "N/A"
Plan? (if this draft/incomplete indicate what you intend to do and how)
What's this PR do?
Fixes a bug whereby we were logging a warning, thereby creating Sentry noise when the
Contribution.canceled_atproperty was referenced on one-time contributions.Why are we doing this? How does it help us?
Reduce Sentry noise.
Are there detailed, specific, step-by-step testing instructions in the associated ticket?
Yes.
Did this PR make changes to the user interface that may require changes to the user-facing docs?
No
Have automated unit tests been added? If not, why?
Yes
How should this change be communicated to end users?
N/A
Are there any smells or added technical debt to note?
No
Has this been documented? If so, where?
N/A
What are the relevant tickets? Add a link to any relevant ones.
DEV5281
Do any changes need to be made before deployment to production (adding environment variables, for example)? If so, open a ticket and link it to the ticket for this PR and list it here:
No
Are there next steps? If so, what? Have tickets been opened for them? List next-step tickets here:
N/A