fix(TMD-1221): update newsletter puff loading #4031
+13
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahim-kurhan
force-pushed
the
fix/TMD-1221-update-newsletter-puff-loading
branch
from
92b68e7 to
4761ba3
Compare
ibrahim-kurhan
force-pushed
the
fix/TMD-1221-update-newsletter-puff-loading
branch
from
c2dec56 to
7874656
Compare
|
milanharia-tm
approved these changes
Jan 13, 2025
amerkadicE
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have been investigating CLS on the website and the automated newsletter puff has been flagged. See video below - the loading state doesn’t match the component and is causing layout shift.
Would be good to get a lighthouse test on it (WebPageTest won’t work as won’t meet the user criteria for rendering it) before and after to note whether it has improved the CLS score.
Check the manually placed Newsletter as well as I believe it’s the same component but could have different loading states, this video is the automated one. Example article: Signs of insider dealing detected in a third of UK takeover bids
JIRA-1221
Checklist