Merge pull request #1855 from russellb/nexctl-peers-ping-output

nexctl: Don't use spinner for parseable output

cmd/nexctl/connectivity.go

@@ -4,12 +4,13 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"github.com/nexodus-io/nexodus/internal/api"
-	"golang.org/x/exp/maps"
 	"os"
 	"sort"
 	"time"
 
+	"github.com/nexodus-io/nexodus/internal/api"
+	"golang.org/x/exp/maps"
+
 	"github.com/briandowns/spinner"
 	"github.com/fatih/color"
 	"github.com/urfave/cli/v3"
@@ -45,19 +46,25 @@ func cmdConnStatus(ctx context.Context, command *cli.Command, family string) err
 		return err
 	}
 
-	// start spinner
-	s := spinner.New(spinner.CharSets[70], 100*time.Millisecond)
-	s.Suffix = " Running Probe..."
-	s.Start()
+	var s *spinner.Spinner
+	if command.String("output") == encodeColumn {
+		// start spinner, but only for human readable output format,
+		// not when generating parseable output.
+		s = spinner.New(spinner.CharSets[70], 100*time.Millisecond)
+		s.Suffix = " Running Probe..."
+		s.Start()
+	}
 
 	result, err := callNexdKeepalives(family)
 	if err != nil {
 		// clear spinner on error return
 		fmt.Print("\r \r")
 		return err
 	}
-	// stop spinner
-	s.Stop()
+	if s != nil {
+		// stop spinner
+		s.Stop()
+	}
 	// clear spinner
 	fmt.Print("\r \r")