Step2: 경로 조회 기능 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 11, 2023 22:09
Hyeon9mak
requested changes
Jun 11, 2023
Comment on lines
+11
to
+12
| public RouteRequest() { | ||
| } |
There was a problem hiding this comment.
jackson 라이브러리 2.13 버전부터 request dto 에 no args constructor 는 필요 없다고 하네요.
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.13
Comment on lines
+35
to
+52
| private DijkstraShortestPath<Station, Section> getShortestPath() { | ||
| List<Station> allStations = stationRepository.findAll(); | ||
| List<Section> allSections = sectionRepository.findAll(); | ||
| WeightedMultigraph<Station, Section> graph = new WeightedMultigraph<>(Section.class); | ||
|
|
||
| for (Station station : allStations) { | ||
| graph.addVertex(station); | ||
| } | ||
| for (Section section : allSections) { | ||
| Station upStation = allStations.stream() | ||
| .filter(station -> station.getId().equals(section.getUpStationId())) | ||
| .findFirst().get(); | ||
| Station downStation = allStations.stream() | ||
| .filter(station -> station.getId().equals(section.getDownStationId())) | ||
| .findFirst().get(); | ||
| graph.setEdgeWeight(graph.addEdge(upStation, downStation), section.getDistance()); | ||
| } | ||
| return new DijkstraShortestPath<>(graph); |
There was a problem hiding this comment.
별개 객체로 분리하면 테스트 코드 작성이 훨씬 편리해지겠는데요? 😄
| @@ -0,0 +1,54 @@ | |||
| package subway.domain.service; | |||
There was a problem hiding this comment.
domain 과 service 의 차이는 무엇일까요?
Comment on lines
+58
to
+67
| @Override | ||
| public Station findByName(String name) { | ||
| String sql = "select * from STATION where name = ?"; | ||
| try { | ||
| return jdbcTemplate.queryForObject(sql, rowMapper, name); | ||
| } catch (Exception e) { | ||
| throw new NoSuchElementException("존재하지 않는 역입니다."); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
저장소에 아이템이 없는게 꼭 예외 상황일까요? 각 상황마다 예외 여부가 달라지지 않을까요? 🤔
Comment on lines
+5
to
+24
| private static final int BASE_FARE = 1250; | ||
| private static final int ADDITIONAL_FARE = 100; | ||
| private static final int FIRST_SURCHARGE_BASE_DISTANCE = 10; | ||
| private static final int SECOND_SURCHARGE_BASE_DISTANCE = 50; | ||
| private static final int FIRST_ADDITIONAL_DISTANCE = 5; | ||
| private static final int SECOND_ADDITIONAL_DISTANCE = 8; | ||
|
|
||
| public static int calculateByDistance(int distance) { | ||
| int fare = BASE_FARE; | ||
|
|
||
| if (distance > SECOND_SURCHARGE_BASE_DISTANCE) { | ||
| int distanceOver50 = distance - SECOND_SURCHARGE_BASE_DISTANCE; | ||
| fare += ((distanceOver50 + SECOND_ADDITIONAL_DISTANCE - 1) / SECOND_ADDITIONAL_DISTANCE) * ADDITIONAL_FARE; | ||
| distance = SECOND_SURCHARGE_BASE_DISTANCE; | ||
| } | ||
| if (distance > FIRST_SURCHARGE_BASE_DISTANCE) { | ||
| int distanceOver10 = distance - FIRST_SURCHARGE_BASE_DISTANCE; | ||
| fare += ((distanceOver10 + FIRST_ADDITIONAL_DISTANCE - 1) / FIRST_ADDITIONAL_DISTANCE) * ADDITIONAL_FARE; | ||
| } | ||
|
|
There was a problem hiding this comment.
상수의 나열과 단순한 연산... enum class 가 떠오르는데요? 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.