Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcListItem): Fix padding in RTL mode. #6359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

falghamdi125
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.50%. Comparing base (cc8130c) to head (a0648d3).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6359      +/-   ##
==========================================
- Coverage   42.52%   42.50%   -0.03%     
==========================================
  Files         156      156              
  Lines        4026     4028       +2     
  Branches     1036     1036              
==========================================
  Hits         1712     1712              
- Misses       2198     2200       +2     
  Partials      116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This fixes the problem from the screen, but the component still has some problems on RTL, for example, with details.

Could you also fix other places where margin/padding sets different left/right values in this component, so it has complete RTL support?

@ShGKme ShGKme added bug Something isn't working feature: list-item Related to the list-item component RTL Right-to-Left languages support labels Jan 9, 2025
@ShGKme ShGKme added this to the 8.21.1 milestone Jan 9, 2025
@falghamdi125 falghamdi125 force-pushed the fix-nclistitem-padding-in-rtl branch from e119ff5 to b379b75 Compare January 12, 2025 22:27
@falghamdi125
Copy link
Contributor Author

Thanks!

This fixes the problem from the screen, but the component still has some problems on RTL, for example, with details.

Could you also fix other places where margin/padding sets different left/right values in this component, so it has complete RTL support?

All set!

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing specificity changes the result.

Elements still has non-logical properties, and after mixing with new logical properties the results changes.

All the properties should be logical to avoid mix caveats.

src/components/NcListItem/NcListItem.vue Outdated Show resolved Hide resolved
@falghamdi125 falghamdi125 force-pushed the fix-nclistitem-padding-in-rtl branch from b379b75 to e8ce3f7 Compare January 14, 2025 03:24
@falghamdi125
Copy link
Contributor Author

Changing specificity changes the result.

Elements still has non-logical properties, and after mixing with new logical properties the results changes.

All the properties should be logical to avoid mix caveats.

I think it's resolved now.

@susnux susnux modified the milestones: 8.21.1, 8.23.0 Jan 15, 2025
Comment on lines +875 to +877
margin-top: 0;
margin-bottom: 0;
margin-inline:0 auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin-top: 0;
margin-bottom: 0;
margin-inline:0 auto;
margin-block: 0;
margin-inline: 0 auto;

@ShGKme ShGKme requested a review from mejo- January 17, 2025 22:23
@ShGKme ShGKme force-pushed the fix-nclistitem-padding-in-rtl branch from e8ce3f7 to a0648d3 Compare January 17, 2025 22:23
@ShGKme
Copy link
Contributor

ShGKme commented Jan 17, 2025

Rebased to include Cypress snapshots fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature: list-item Related to the list-item component RTL Right-to-Left languages support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] NcListItem padding in RTL mode
3 participants