-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcListItem): Fix padding in RTL mode. #6359
base: master
Are you sure you want to change the base?
fix(NcListItem): Fix padding in RTL mode. #6359
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6359 +/- ##
==========================================
- Coverage 42.52% 42.50% -0.03%
==========================================
Files 156 156
Lines 4026 4028 +2
Branches 1036 1036
==========================================
Hits 1712 1712
- Misses 2198 2200 +2
Partials 116 116 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This fixes the problem from the screen, but the component still has some problems on RTL, for example, with details.
Could you also fix other places where margin/padding
sets different left/right
values in this component, so it has complete RTL support?
e119ff5
to
b379b75
Compare
All set! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing specificity changes the result.
Elements still has non-logical properties, and after mixing with new logical properties the results changes.
All the properties should be logical to avoid mix caveats.
b379b75
to
e8ce3f7
Compare
I think it's resolved now. |
margin-top: 0; | ||
margin-bottom: 0; | ||
margin-inline:0 auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
margin-top: 0; | |
margin-bottom: 0; | |
margin-inline:0 auto; | |
margin-block: 0; | |
margin-inline: 0 auto; |
Signed-off-by: Faisal Alghamdi <[email protected]>
e8ce3f7
to
a0648d3
Compare
Rebased to include Cypress snapshots fix |
☑️ Resolves
🖼️ Screenshots