Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcDateTimePickerNative): do not set invalid value #6387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 15, 2025

☑️ Resolves

  • Fix setting this.model twice from @input events (invalid, 'month')

🖼️ Screenshots

🏚️ Before 🏡 After
image image

Docs:
image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component labels Jan 15, 2025
@Antreesy Antreesy added this to the 8.21.1 milestone Jan 15, 2025
@Antreesy Antreesy self-assigned this Jan 15, 2025
@Antreesy Antreesy marked this pull request as draft January 15, 2025 13:29
@Antreesy Antreesy force-pushed the fix/noid/date-picker-invalid branch 2 times, most recently from 088b166 to 6c097e0 Compare January 15, 2025 13:59
@Antreesy Antreesy marked this pull request as ready for review January 15, 2025 13:59
@Antreesy Antreesy requested a review from susnux January 15, 2025 15:10
@Antreesy Antreesy force-pushed the fix/noid/date-picker-invalid branch from 6c097e0 to a935181 Compare January 15, 2025 15:43
}
},
}
</script>
<style>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<style>
<style scoped>

@susnux susnux modified the milestones: 8.21.1, 8.23.0 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: datepicker Related to the date/time picker component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants