Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): update snapshots #6388

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(cypress): update snapshots #6388

merged 1 commit into from
Jan 15, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 15, 2025

Update snapshots due to failing CI

It is super annoying:

  1. Wait for Cypress to fail
  2. Download the snapshots from CI (on the summary tab of the Cypress run)
  3. Move the "actual" from the downloaded zip to "base" of the repository
  4. Only commit changed files not new ones

is anoying because the folder structure is not the same and there are even files that do not exist in base ...

This is needed because CI somehow uses other fonts then locally (and for me it even uses other font scaling (even it is black text it will use colors for subsampling)...

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy self-assigned this Jan 15, 2025
@Antreesy Antreesy marked this pull request as ready for review January 15, 2025 14:32
@susnux susnux added the 3. to review Waiting for reviews label Jan 15, 2025
@susnux susnux added this to the 8.21.1 milestone Jan 15, 2025
@susnux susnux requested a review from ShGKme January 15, 2025 15:02
@Antreesy Antreesy merged commit 534ca1b into master Jan 15, 2025
20 checks passed
@Antreesy Antreesy deleted the fix/cypress branch January 15, 2025 15:09
@susnux susnux modified the milestones: 8.21.1, 8.23.0 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants