Skip to content

Commit

Permalink
Merge master
Browse files Browse the repository at this point in the history
Signed-off-by: alperozturk <[email protected]>
  • Loading branch information
alperozturk96 committed Nov 1, 2023
2 parents def744b + b188af0 commit b906724
Show file tree
Hide file tree
Showing 52 changed files with 1,409 additions and 1,316 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ We use [shot](https://github.com/Karumi/Shot) for taking screenshots and compare
Screenshot.snapActivity(activity).record();
```

- best practise is to first create test with emulator too see behaviour and then create screenshots
- best practice is to first create test with emulator too see behaviour and then create screenshots

## File naming

Expand Down
2 changes: 1 addition & 1 deletion SETUP.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ To set up the project in Android Studio follow the next steps:

* Open Android Studio and select 'Import Project (Eclipse ADT, Gradle, etc)'. Browse through your file system to the folder 'android' where the project is located. Android Studio will then create the '.iml' files it needs. If you ever close the project but the files are still there, you just select 'Open Project…'. The file chooser will show an Android face as the folder icon, which you can select to reopen the project.
* Android Studio will try to build the project directly after importing it. To build it manually, follow the menu path 'Build'/'Make Project', or just click the 'Play' button in the toolbar to build and run it in a mobile device or an emulator. The resulting APK file will be saved in the 'build/outputs/apk/' subdirectory in the project folder.
* Setup Android Studio editor configurtation for the project: ```Settings``````Editor``````Code Style``````Scheme: Project``` and ```Enable EditorConfig support```
* Setup Android Studio editor configuration for the project: ```Settings``````Editor``````Code Style``````Scheme: Project``` and ```Enable EditorConfig support```


### 3. Working in a terminal with Gradle:
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
73 changes: 0 additions & 73 deletions app/src/main/java/com/nextcloud/client/di/ActivityInjector.java

This file was deleted.

62 changes: 62 additions & 0 deletions app/src/main/java/com/nextcloud/client/di/ActivityInjector.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
/*
* Nextcloud Android client application
*
* @author Chris Narkiewicz
* Copyright (C) 2019 Chris Narkiewicz <[email protected]>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package com.nextcloud.client.di

import android.app.Activity
import android.app.Application.ActivityLifecycleCallbacks
import android.os.Bundle
import androidx.fragment.app.FragmentActivity
import dagger.android.AndroidInjection

class ActivityInjector : ActivityLifecycleCallbacks {
override fun onActivityCreated(activity: Activity, savedInstanceState: Bundle?) {
if (activity is Injectable) {
AndroidInjection.inject(activity)
}
if (activity is FragmentActivity) {
val fm = activity.supportFragmentManager
fm.registerFragmentLifecycleCallbacks(FragmentInjector(), true)
}
}

override fun onActivityStarted(activity: Activity) {
// unused atm
}

override fun onActivityResumed(activity: Activity) {
// unused atm
}

override fun onActivityPaused(activity: Activity) {
// unused atm
}

override fun onActivityStopped(activity: Activity) {
// unused atm
}

override fun onActivitySaveInstanceState(activity: Activity, outState: Bundle) {
// unused atm
}

override fun onActivityDestroyed(activity: Activity) {
// unused atm
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
import com.owncloud.android.ui.dialog.RemoveFilesDialogFragment;
import com.owncloud.android.ui.dialog.RenameFileDialogFragment;
import com.owncloud.android.ui.dialog.RenamePublicShareDialogFragment;
import com.owncloud.android.ui.dialog.SendFilesDialog;
import com.owncloud.android.ui.dialog.SendShareDialog;
import com.owncloud.android.ui.dialog.SetupEncryptionDialogFragment;
import com.owncloud.android.ui.dialog.SharePasswordDialogFragment;
Expand Down Expand Up @@ -460,6 +461,9 @@ abstract class ComponentsModule {
@ContributesAndroidInjector
abstract FileActionsBottomSheet fileActionsBottomSheet();

@ContributesAndroidInjector
abstract SendFilesDialog sendFilesDialog();

@ContributesAndroidInjector
abstract DocumentScanActivity documentScanActivity();

Expand Down
Loading

0 comments on commit b906724

Please sign in to comment.