Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly update file after sharing #11775

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tobiasKaminsky
Copy link
Member

Step to reproduce:

  1. Open the NextCloud app and login
  2. Click on share icon of any file- Image/video/audio/ office file
  3. Click on "Link" from its popup
  4. Now check the icon

Actual result:
Share-Icon is remain same . When refresh the page then icon gets change as link icon

Expected result:
Icon should get change after link share from its popup

  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.25

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jun 28, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Aug 28, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Oct 18, 2023
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Oct 20, 2023
@tobiasKaminsky tobiasKaminsky force-pushed the updateShareIcon branch 2 times, most recently from 4c86520 to 09a7c8c Compare November 20, 2023 08:07
@tobiasKaminsky
Copy link
Member Author

/rebase

surinder-tsys added a commit to nextmcloud/android that referenced this pull request Jan 10, 2024
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Feb 8, 2024
surinder-tsys added a commit to nextmcloud/android that referenced this pull request Feb 14, 2024
tobiasKaminsky and others added 2 commits April 7, 2024 21:48
…apter.java

Co-authored-by: Tom <[email protected]>
Signed-off-by: Tobias Kaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Copy link

github-actions bot commented Apr 7, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11775.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

github-actions bot commented Apr 7, 2024

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6767
Correctness6868
Dodgy code350350
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5858
Security1919
Total578578

Copy link

github-actions bot commented Apr 7, 2024

github-actions bot pushed a commit to nextmcloud/android that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants