Migrate to media3 and Immersive mode for video playback

[parneet-guraya]

Closes: #11829

What this PR includes?

• Changes from migration script (for migrating from exoplayer2 to media3).
• Remove the old way to watch video full screen with creating a new dialog (which is breaking in new media3 API)
• New functionality to go full screen(immersive mode) when playing video.
• Tests written, or not not needed

Before

Before.mp4

After

After.mp4

[parneet-guraya]

Hi,
Please let me know how the Immersive Mode is doing and If it needs some improvement (transition wise), I sure can look into it and maybe take inspiration from Google Drive, Whatsapp etc. (Since it wasn't the scope of the PR, I didn't do it here)

Let me know what do you think and if it needs some polishing.

Thanks!

[ZetaTom]

Works as expected on my end.

One minor observation: when in light mode and playing a video file, the background and action bar remain white, which looks a bit odd. I'm not sure how, or even if, this was handled before...

[parneet-guraya]

@ZetaTom Yes, the white background does not look nice.So, I think I will change the background color to black (for video only) so it shows black background instead of white.

However the action bar has the same white color as it is in the current nextcloud app, so you are correct it's not handled.

We can render the Preview Media(for both audio and video) Fragment as it gets rendered in dark mode? If yes, let me know I can try that and create a new PR (not adding here since that will populate the PR with too much different changes which should be standalone)

This is how Google Drive's media playback UI looks like (in light mode)

Record_2023-09-05-22-52-13.mp4

For both video and audio playbacks it has default dark UI (for both light and dark mode)

[parneet-guraya]

This is how it looks with background black (only done for videos)

Record_2023-09-06-01-06-17.mp4

[AndyScherzinger]

@parneet-guraya thanks a lot for working on this migration. Can you please address the newly introduced lint errors? See https://www.kaminsky.me/nc-dev/android-lint/5531.html

Thanks in advance, highly appreciate your contributions 🤩

[parneet-guraya]

Hi, @AndyScherzinger, I'm happy to contribute 😄
You can see here about the lint errors.

If you don't require strict binary compatibility, these errors can be safely suppressed with an @OptIn annotation.

I'm not really sure about what binary compatibility they are referring to tell me if that is something concerning otherwise we can use the annotation as mentioned, although I did use the annotation I think I didn't do properly in a file that's why lint error, I fixed it and pushing again to see if the lint error goes.

[parneet-guraya]

Found out the status bar color is not applied when handling display cutout in the FileDisplayActivity. Handling for display cutout is only applied in activities but we're have media playback inside a fragment.So, that's the reason for handling display cutout in the launching activity but then status bar color does not apply. Looking into it, so marking it as draft and removing review requests.

[parneet-guraya]

@alperozturk96 Done 👍

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	69	69
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	69	69
Dodgy code	353	353
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	54	54
Security	18	18
Total	542	542

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11936.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[JonasMayerDev]

Works as expected for me :)

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!