-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix Disable focus change via tap #12068
Bugfix Disable focus change via tap #12068
Conversation
Great so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not jump to 1st position after entering 4th digit
Hm. I just tested it with master and this is the already existing behaviour. |
@tobiasKaminsky Done |
cb71b79
to
23097c8
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
23097c8
to
6a9f51b
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12068.apk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my tests, actual input worked well with the virtual keypad and an external keyboard. However, the backspace key on the virtual keypad didn't work. Pressing the backspace key on the external keyboard resulted in one, or sometimes several, inputs being deleted.
I think external keyboard cannot be used for testing with an emulator. |
Users are capable of inadvertently changing focus through tapping, which can result in accidental input and lead to confusion for App passcode enter.