Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Disable focus change via tap #12068

Conversation

alperozturk96
Copy link
Collaborator

Users are capable of inadvertently changing focus through tapping, which can result in accidental input and lead to confusion for App passcode enter.

  • [ Done ] Tests written, or not not needed

@tobiasKaminsky
Copy link
Member

Great so far.
One small thing: When I enter last digit, higlighted bar is then again at first one.
After a very short timespan then the app is unlocked.
I think it should remain on 4th position.

Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not jump to 1st position after entering 4th digit

@tobiasKaminsky
Copy link
Member

Hm. I just tested it with master and this is the already existing behaviour.
Can you nevertheless check if this is quickly possible?
If not, we can keep it this way and directly merge your PR.

@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky Done

@alperozturk96 alperozturk96 changed the title Disable focus change via tap Bugfix Disable focus change via tap Oct 26, 2023
@alperozturk96 alperozturk96 requested a review from ZetaTom November 1, 2023 12:30
@AndyScherzinger AndyScherzinger force-pushed the bugfix/app-not-switching-to-next-fields-after-entering-pin-number branch 2 times, most recently from cb71b79 to 23097c8 Compare November 1, 2023 22:53
@AndyScherzinger AndyScherzinger force-pushed the bugfix/app-not-switching-to-next-fields-after-entering-pin-number branch from 23097c8 to 6a9f51b Compare November 2, 2023 09:50
Copy link

github-actions bot commented Nov 2, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12068.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

github-actions bot commented Nov 2, 2023

Codacy

Lint

TypemasterPR
Warnings7777
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7872
Dodgy code367367
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total569563

Copy link
Collaborator

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my tests, actual input worked well with the virtual keypad and an external keyboard. However, the backspace key on the virtual keypad didn't work. Pressing the backspace key on the external keyboard resulted in one, or sometimes several, inputs being deleted.

@tobiasKaminsky
Copy link
Member

I think external keyboard cannot be used for testing with an emulator.

@tobiasKaminsky tobiasKaminsky merged commit 28f54f3 into master Nov 6, 2023
18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/app-not-switching-to-next-fields-after-entering-pin-number branch November 6, 2023 14:38
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants