Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert create folder dialog to kt #12071

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Convert create folder dialog to kt #12071

merged 6 commits into from
Nov 1, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 20, 2023 •
edited by AndyScherzinger
Loading

  • Tests written, or not not needed

@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-create-folder-dialog-to-kt branch 3 times, most recently from 4413959 to 3584f1b Compare October 30, 2023 18:37
@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-create-folder-dialog-to-kt branch from a01c4af to e362fbb Compare October 31, 2023 18:50
alperozturk96 and others added 6 commits October 31, 2023 21:30
@alperozturk96 @AndyScherzinger
Rename .java to .kt
4f4216e 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Convert to kt
80befe4 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Add line eof
e1554ae 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Add suppress for TextWatcher
3e20243 
Signed-off-by: alperozturk <[email protected]>
@AndyScherzinger
remove unneeded empty line
b61da53 
Signed-off-by: Andy Scherzinger <[email protected]>
@alperozturk96 @AndyScherzinger
Fix kotlin spotless check
b87bbdd 
Signed-off-by: alperozturk <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-create-folder-dialog-to-kt branch from e362fbb to b87bbdd Compare October 31, 2023 20:30
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7878
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7878
Dodgy code377372
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5656
Security1818
Total577572

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12071.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger merged commit 5fc10be into master Nov 1, 2023
18 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-create-folder-dialog-to-kt branch November 1, 2023 11:53
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger