Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Account Removal Confirmation Dialog Java to Kotlin #12072

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Convert Account Removal Confirmation Dialog Java to Kotlin #12072

merged 3 commits into from
Oct 31, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 20, 2023 •
edited by AndyScherzinger
Loading

  • Tests written, or not not needed

@alperozturk96 alperozturk96 changed the title Convert Account Removal Confirmation Dialog java to kotlin Convert Account Removal Confirmation Dialog Java to kotlin Oct 20, 2023
@alperozturk96 alperozturk96 changed the title Convert Account Removal Confirmation Dialog Java to kotlin Convert Account Removal Confirmation Dialog Java to Kotlin Oct 20, 2023
@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-AccountRemovalConfirmationDialog-kt branch 2 times, most recently from cf8cbf4 to b9d01d4 Compare October 30, 2023 18:38
alperozturk96 and others added 3 commits October 31, 2023 19:51
@alperozturk96 @AndyScherzinger
Rename .java to .kt
0f0ca2d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Convert to kt
c6b6225 
Signed-off-by: alperozturk <[email protected]>
@AndyScherzinger
remove unneeded empty lines
64f4c46 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-AccountRemovalConfirmationDialog-kt branch from 9ee45fd to 64f4c46 Compare October 31, 2023 18:51
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 31, 2023
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7878
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7878
Dodgy code377377
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5656
Security1818
Total577577

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12072.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger merged commit fb12c54 into master Oct 31, 2023
16 of 18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-AccountRemovalConfirmationDialog-kt branch October 31, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger