Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings for FilesDisplayActivity #12113

Closed
wants to merge 5 commits into from
Closed

Fix warnings for FilesDisplayActivity #12113

wants to merge 5 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 31, 2023 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96 alperozturk96 requested a review from ZetaTom October 31, 2023 14:13
alperozturk96
alperozturk96 commented Oct 31, 2023
View reviewed changes
app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java Outdated
@@ -2338,44 +2291,6 @@ public void showFiles(boolean onDeviceOnly) {
}
}

@Subscribe(threadMode = ThreadMode.BACKGROUND)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused functions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky might know this better, but I expect these functions to be used by the event bus, so the code checks are false positives.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some testing and found out, that these functions are indeed called when an event is dispatched on the eventbus.

For example, public void onMessageEvent(final SearchEvent event) is called, when the user switches to the Favourites tab from the main All files view.

@AndyScherzinger AndyScherzinger force-pushed the refactor/FileDisplayActivity branch from b906724 to e17f2bf Compare November 1, 2023 14:39
AndyScherzinger
AndyScherzinger requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment, best to check with Tobias

app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java Outdated
@@ -2338,44 +2291,6 @@ public void showFiles(boolean onDeviceOnly) {
}
}

@Subscribe(threadMode = ThreadMode.BACKGROUND)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky might know this better, but I expect these functions to be used by the event bus, so the code checks are false positives.

@AndyScherzinger AndyScherzinger force-pushed the refactor/FileDisplayActivity branch from e17f2bf to e6dc160 Compare November 2, 2023 09:53
@alperozturk96
Copy link
Collaborator Author

/rebase

@nextcloud-command nextcloud-command force-pushed the refactor/FileDisplayActivity branch from 0e8ce06 to ae72d9b Compare November 10, 2023 09:17
@alperozturk96
Copy link
Collaborator Author

/rebase

@nextcloud-command nextcloud-command force-pushed the refactor/FileDisplayActivity branch from a398f10 to 799bc49 Compare November 14, 2023 09:59
@alperozturk96
Copy link
Collaborator Author

/rebase

@tobiasKaminsky
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the refactor/FileDisplayActivity branch from 799bc49 to 818c1bc Compare November 20, 2023 08:00
@alperozturk96
Copy link
Collaborator Author

/rebase

@nextcloud-command nextcloud-command force-pushed the refactor/FileDisplayActivity branch from 818c1bc to 81a6cd3 Compare November 20, 2023 10:05
@alperozturk96
Copy link
Collaborator Author

/rebase

@nextcloud-command nextcloud-command force-pushed the refactor/FileDisplayActivity branch from f236adb to 7034377 Compare November 21, 2023 12:25
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12113.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@tobiasKaminsky
Copy link
Member

/rebase

@alperozturk96 @tobiasKaminsky
Fix warnings
0f5f05e 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @tobiasKaminsky
Revert onMessageEvent functions
c5f8974 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @tobiasKaminsky
Reduce warnings
95af136 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @tobiasKaminsky
Reduce spotbugs
db7d539 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @tobiasKaminsky
Reduce spotbugs
46d374a 
Signed-off-by: alperozturk <[email protected]>
@nextcloud-command nextcloud-command force-pushed the refactor/FileDisplayActivity branch from 7034377 to 46d374a Compare December 3, 2023 08:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

Codacy

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7070
Dodgy code360360
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5857
Security1818
Total554553

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96
Copy link
Collaborator Author

Outdated PR, too much diff to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees
No one assigned
Labels
4. to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alperozturk96 @tobiasKaminsky @AndyScherzinger @ZetaTom