Fix Race Condition on Passcode Manager #12125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
alperozturk96
requested review from
AndyScherzinger,
JonasMayerDev and
ZetaTom
ZetaTom
requested changes
Nov 8, 2023
Signed-off-by: alperozturk <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12125.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
@ZetaTom @tobiasKaminsky Waiting response from you regarding this comment so that I continue work on this PR. |
@alperozturk96, please have a look at the private message I have sent you. |
tobiasKaminsky
deleted the
bugfix/race-condition-on-pass-code-manager-#478
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normal App Launch Test After Fix:
https://github.com/nextcloud/android/assets/67455295/82b15096-741d-4236-8a8e-0c217b6bfd73
Exploit App Launch Test After Fix:
https://github.com/nextcloud/android/assets/67455295/e0f24aac-c730-4663-ba14-12a3452025f0
Useful Info:
Synchronized