Live Photo #12139

alperozturk96 · 2023-11-06T10:49:33Z

Resolves #12124

Live Photo Indicator List View:

Live Photo Indicator Grid View:

Live Photo Indicator List View SFSymbol Alternative:

Live Photo Indicator Grid View SFSymbol Alternative:

@nextcloud/designers How does the live photo indicator look? I think the position and color can be better, but nothing come in my mind in this regard.

Tests written, or not not needed

Signed-off-by: alperozturk <[email protected]>

AndyScherzinger · 2023-11-06T11:19:34Z

@alperozturk96 the icon is: https://developer.apple.com/live-photos/ So I would just use that, no?

See https://thenounproject.com/browse/icons/term/live-photo/ for svg resources, maybe @jancborchardt or @nimishavijay can pick one? :)

alperozturk96 · 2023-11-06T11:25:24Z

@AndyScherzinger I agree that icon more suitable. @tobiasKaminsky suggested that icon. If it's okay for all of us I can change.

jancborchardt · 2023-11-06T11:40:09Z

This icon seems to be the closest to Apple’s live photo icon: https://thenounproject.com/icon/play-live-photo-710577/

Signed-off-by: alperozturk <[email protected]>

alperozturk96 · 2023-11-06T11:59:15Z

Icons updated @AndyScherzinger @jancborchardt

jancborchardt · 2023-11-06T13:01:29Z

@alperozturk96 sorry, the actual icon Apple uses is https://thenounproject.com/icon/live-photo-710576/, not the one with the play icon, my mistake.

Also, the iOS Photos app only shows the "Live" indicator when in the photo detail view, not overlaid on each photo as this makes the grid view very busy. I would say we should do it similarly to keep it clean and focused on the photos.

https://support.apple.com/en-gb/HT207310

AndyScherzinger · 2023-11-06T14:12:56Z

app/src/main/res/layout/list_item.xml

            android:paddingStart="@dimen/standard_half_padding"
            android:paddingEnd="@dimen/alternate_padding"
            android:src="@drawable/ic_checkbox_blank_outline" />

        <ImageView
            android:id="@+id/overflow_menu"
-            android:layout_width="48dp"


48dp is needed for Accessibility, icon hitboxes need to be at least 48dp in size

There is a dimens value for that also 👍

AndyScherzinger · 2023-11-06T14:15:03Z

@jancborchardt i.e. amazon is showing it, which I think makes sense, since we are not the Apple Image viewer but a general EFSS in this case, so if we then hide the mov file in these file lists than we might want to indicate a live photo as such, no?

Signed-off-by: alperozturk <[email protected]>

AndyScherzinger · 2023-11-06T15:57:45Z

For the overlay in the grid view this definitely needs a background container to "punch out" the icon, else it is extremely hard to spot. So I would suggest just using the background color (surface), semi-transparent might look strange, on the other hand the share icon has the same issue too.

@jancborchardt

jancborchardt · 2023-11-06T16:47:23Z

Ok, then if we show it I would say

Position: bottom left of the preview, with some padding to the sides
Style-wise do it like Apple, semi-transparent grey backdrop so the icon has contrast

AndyScherzinger · 2023-11-06T18:48:30Z

Style-wise do it like Apple, semi-transparent grey backdrop so the icon has contrast

@jancborchardt can maybe @marcoambrosini check how Apple displays it on dark mode (since I only have Android)

marcoambrosini · 2023-11-07T01:49:01Z

@AndyScherzinger is this what you need?

Signed-off-by: alperozturk <[email protected]>

AndyScherzinger · 2023-11-07T09:32:23Z

@AndyScherzinger is this what you need?

perfect, yes, thanks @marcoambrosini 👍

Signed-off-by: alperozturk <[email protected]>

AndyScherzinger · 2023-11-07T10:30:57Z

app/src/main/java/com/owncloud/android/db/ProviderMeta.java

@@ -35,7 +35,7 @@
 */
 public class ProviderMeta {
    public static final String DB_NAME = "filelist";
-    public static final int DB_VERSION = 73;
+    public static final int DB_VERSION = 75;


DB version bump by 2? Also where is the new json schema for DB?

I was testing. Multiple times I came across with conflict and I was increasing one by one whenever I got that issue. I remember first one was 74 then I put 75 nevertheless after complete all implementation I am going to check all changes. Thanks for the early notice.

Signed-off-by: tobiasKaminsky <[email protected]>

JonasMayerDev · 2023-12-06T11:15:35Z

Hi, I noticed some bugs.

Live icon seems odd to me when live photo is opened (is there supposed to be a text?)
Clicking on live icon multiple times when opened crashes app (and leads to unexpected behavior) -> Just not listen to clicks when video is playing?

Record_2023-12-06-12-04-08.mp4

Options Button in opened live photo crashes the app for me.

Record_2023-12-06-12-04-31.mp4

JonasMayerDev

Fix described bugs

alperozturk96 · 2023-12-06T11:52:47Z

Hi, I noticed some bugs.

Live icon seems odd to me when live photo is opened (is there supposed to be a text?)

Clicking on live icon multiple times when opened crashes app (and leads to unexpected behavior) -> Just not listen to clicks when video is playing?

Record_2023-12-06-12-04-08.mp4
3. Options Button in opened live photo crashes the app for me.

Record_2023-12-06-12-04-31.mp4

Could you share crash report?

JonasMayerDev · 2023-12-06T12:17:08Z

For 2.:
2023-12-06 13:11:22.543 14499-14499 AndroidRuntime com.nextcloud.android.qa E FATAL EXCEPTION: main Process: com.nextcloud.android.qa, PID: 14499 java.lang.NullPointerException: Attempt to read from field 'com.google.android.exoplayer2.ui.StyledPlayerView com.owncloud.android.databinding.FragmentPreviewMediaBinding.exoplayerView' on a null object reference in method 'void com.owncloud.android.ui.preview.PreviewMediaFragment.lambda$onStart$1()' at com.owncloud.android.ui.preview.PreviewMediaFragment.lambda$onStart$1(PreviewMediaFragment.java:370) at com.owncloud.android.ui.preview.PreviewMediaFragment.$r8$lambda$AkxMJlf2KgePzqOIh5h57BVdLW8(Unknown Source:0) at com.owncloud.android.ui.preview.PreviewMediaFragment$$ExternalSyntheticLambda0.run(Unknown Source:2) at android.os.Handler.handleCallback(Handler.java:938) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loopOnce(Looper.java:233) at android.os.Looper.loop(Looper.java:344) at android.app.ActivityThread.main(ActivityThread.java:8248) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:589) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1071)

For 3.:
2023-12-06 13:14:26.365 12650-12650 AndroidRuntime com.nextcloud.android.qa E at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at android.app.Activity.onMenuItemSelected(Activity.java:4404) at androidx.activity.ComponentActivity.onMenuItemSelected(ComponentActivity.java:528) at androidx.fragment.app.FragmentActivity.onMenuItemSelected(FragmentActivity.java:264) at androidx.appcompat.app.AppCompatActivity.onMenuItemSelected(AppCompatActivity.java:269) at androidx.appcompat.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:110) at androidx.appcompat.app.AppCompatDelegateImpl.onMenuItemSelected(AppCompatDelegateImpl.java:1259) at androidx.appcompat.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:836) at androidx.appcompat.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:159) at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:987) at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:977) at androidx.appcompat.widget.ActionMenuView.invokeItem(ActionMenuView.java:625) at androidx.appcompat.view.menu.ActionMenuItemView.onClick(ActionMenuItemView.java:156) at android.view.View.performClick(View.java:7498) at android.view.View.performClickInternal(View.java:7471) at android.view.View.access$3700(View.java:843) at android.view.View$PerformClick.run(View.java:29098) at android.os.Handler.handleCallback(Handler.java:938) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loopOnce(Looper.java:233) at android.os.Looper.loop(Looper.java:344) at android.app.ActivityThread.main(ActivityThread.java:8248) at java.lang.reflect.Method.invoke(Native Method) 2023-12-06 13:14:26.365 12650-12650 AndroidRuntime com.nextcloud.android.qa E at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:589) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1071)

I get "com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226)" a hundred time befor app actually crashes for some reason (or logger bug?)

alperozturk96 · 2023-12-06T12:36:24Z

For 2.: 2023-12-06 13:11:22.543 14499-14499 AndroidRuntime com.nextcloud.android.qa E FATAL EXCEPTION: main Process: com.nextcloud.android.qa, PID: 14499 java.lang.NullPointerException: Attempt to read from field 'com.google.android.exoplayer2.ui.StyledPlayerView com.owncloud.android.databinding.FragmentPreviewMediaBinding.exoplayerView' on a null object reference in method 'void com.owncloud.android.ui.preview.PreviewMediaFragment.lambda$onStart$1()' at com.owncloud.android.ui.preview.PreviewMediaFragment.lambda$onStart$1(PreviewMediaFragment.java:370) at com.owncloud.android.ui.preview.PreviewMediaFragment.$r8$lambda$AkxMJlf2KgePzqOIh5h57BVdLW8(Unknown Source:0) at com.owncloud.android.ui.preview.PreviewMediaFragment$$ExternalSyntheticLambda0.run(Unknown Source:2) at android.os.Handler.handleCallback(Handler.java:938) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loopOnce(Looper.java:233) at android.os.Looper.loop(Looper.java:344) at android.app.ActivityThread.main(ActivityThread.java:8248) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:589) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1071)

For 3.: 2023-12-06 13:14:26.365 12650-12650 AndroidRuntime com.nextcloud.android.qa E at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226) at android.app.Activity.onMenuItemSelected(Activity.java:4404) at androidx.activity.ComponentActivity.onMenuItemSelected(ComponentActivity.java:528) at androidx.fragment.app.FragmentActivity.onMenuItemSelected(FragmentActivity.java:264) at androidx.appcompat.app.AppCompatActivity.onMenuItemSelected(AppCompatActivity.java:269) at androidx.appcompat.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:110) at androidx.appcompat.app.AppCompatDelegateImpl.onMenuItemSelected(AppCompatDelegateImpl.java:1259) at androidx.appcompat.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:836) at androidx.appcompat.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:159) at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:987) at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:977) at androidx.appcompat.widget.ActionMenuView.invokeItem(ActionMenuView.java:625) at androidx.appcompat.view.menu.ActionMenuItemView.onClick(ActionMenuItemView.java:156) at android.view.View.performClick(View.java:7498) at android.view.View.performClickInternal(View.java:7471) at android.view.View.access$3700(View.java:843) at android.view.View$PerformClick.run(View.java:29098) at android.os.Handler.handleCallback(Handler.java:938) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loopOnce(Looper.java:233) at android.os.Looper.loop(Looper.java:344) at android.app.ActivityThread.main(ActivityThread.java:8248) at java.lang.reflect.Method.invoke(Native Method) 2023-12-06 13:14:26.365 12650-12650 AndroidRuntime com.nextcloud.android.qa E at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:589) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1071)

I get "com.owncloud.android.ui.preview.PreviewImageActivity.onOptionsItemSelected(PreviewImageActivity.java:226)" a hundred time befor app actually crashes for some reason (or logger bug?)

This bug fixed in this PR already

Signed-off-by: alperozturk <[email protected]>

Signed-off-by: github-actions <[email protected]>

Signed-off-by: alperozturk <[email protected]>

…/live-photo

Signed-off-by: alperozturk <[email protected]>

Signed-off-by: github-actions <[email protected]>

Signed-off-by: alperozturk <[email protected]>

github-actions · 2023-12-08T11:49:42Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12139.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions · 2023-12-08T11:50:24Z

Codacy

Lint

Type	master	PR
Warnings	75	73
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	68	68
Dodgy code	360	360
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	58	55
Security	18	18
Total	552	549

tobiasKaminsky · 2023-12-08T15:31:48Z

/backport to stable-3.27

alperozturk96 added 7 commits November 6, 2023 11:12

Add indicator word and icon

50567dd

Signed-off-by: alperozturk <[email protected]>

Add indicator in list_item

3f0a049

Signed-off-by: alperozturk <[email protected]>

Add live photo indicator for grid view

3abb630

Signed-off-by: alperozturk <[email protected]>

Update ViewHolders for live photo indicator

cc03aa9

Signed-off-by: alperozturk <[email protected]>

Update OCFile for live photo ability

e925ce9

Signed-off-by: alperozturk <[email protected]>

Add missing live photo indicator for grid

eb0aa90

Signed-off-by: alperozturk <[email protected]>

Update oc file adapter for live photo indicator

0ff650d

Signed-off-by: alperozturk <[email protected]>

alperozturk96 added the 2. developing label Nov 6, 2023

Fix alignment in grid mode

c45e786

Signed-off-by: alperozturk <[email protected]>

alperozturk96 added 2 commits November 6, 2023 12:40

Add long click listener for live photo

cf71e59

Signed-off-by: alperozturk <[email protected]>

Change icon with sf symbol

eae0947

Signed-off-by: alperozturk <[email protected]>

AndyScherzinger reviewed Nov 6, 2023

View reviewed changes

alperozturk96 added 3 commits November 6, 2023 16:13

Fix hitboxes for accesibilty

4807c17

Signed-off-by: alperozturk <[email protected]>

Add playLivePhoto functionality to image fragment

c1c9d94

Signed-off-by: alperozturk <[email protected]>

Add new property

2c499ef

Signed-off-by: alperozturk <[email protected]>

Check LivePhotoIndicatorSeparator

c350d4f

Signed-off-by: alperozturk <[email protected]>

alperozturk96 added 2 commits November 7, 2023 10:55

Add live photo field usage

38b9548

Signed-off-by: alperozturk <[email protected]>

Add live photo field to OCFile

b4d9ab0

Signed-off-by: alperozturk <[email protected]>

AndyScherzinger reviewed Nov 7, 2023

View reviewed changes

backportbot-nextcloud bot added the backport-request label Dec 6, 2023

add test

a47ed56

Signed-off-by: tobiasKaminsky <[email protected]>

JonasMayerDev requested changes Dec 6, 2023

View reviewed changes

alperozturk96 and others added 4 commits December 6, 2023 15:27

Fix merge conflict

2f1e3ea

Signed-off-by: alperozturk <[email protected]>

Analysis: update lint results to reflect reduced error/warning count

2eb8245

Signed-off-by: github-actions <[email protected]>

Fix crashes

b493c67

Signed-off-by: alperozturk <[email protected]>

Merge remote-tracking branch 'origin/feature/live-photo' into feature…

d6657c9

…/live-photo

alperozturk96 requested a review from JonasMayerDev December 6, 2023 14:57

alperozturk96 added 3 commits December 6, 2023 16:06

Fix text color for live photo indicator

2077bf9

Signed-off-by: alperozturk <[email protected]>

Merge master

0028d8e

Signed-off-by: alperozturk <[email protected]>

Solve git conflicts

7f70b1c

Signed-off-by: alperozturk <[email protected]>

alperozturk96 added 2. developing and removed 4. to release labels Dec 7, 2023

Analysis: update lint results to reflect reduced error/warning count

6f1b62f

Signed-off-by: github-actions <[email protected]>

alperozturk96 added 4. to release and removed 2. developing labels Dec 7, 2023

alperozturk96 added 3 commits December 8, 2023 11:47

Use file id for merging live photos

b48c027

Signed-off-by: alperozturk <[email protected]>

Use file id for merging live photos

7719b2e

Signed-off-by: alperozturk <[email protected]>

Fix tests

633f458

Signed-off-by: alperozturk <[email protected]>

tobiasKaminsky merged commit fa07aad into master Dec 8, 2023
19 of 20 checks passed

delete-merged-branch bot deleted the feature/live-photo branch December 8, 2023 13:17

tobiasKaminsky removed the backport-request label Dec 8, 2023

joshtrichards mentioned this pull request Dec 9, 2023

Motion image support in android app #5375

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Live Photo #12139

Live Photo #12139

alperozturk96 commented Nov 6, 2023 •

edited by AndyScherzinger

Loading

AndyScherzinger commented Nov 6, 2023

alperozturk96 commented Nov 6, 2023

jancborchardt commented Nov 6, 2023

alperozturk96 commented Nov 6, 2023

jancborchardt commented Nov 6, 2023

AndyScherzinger Nov 6, 2023

AndyScherzinger Nov 6, 2023

AndyScherzinger commented Nov 6, 2023

AndyScherzinger commented Nov 6, 2023

jancborchardt commented Nov 6, 2023

AndyScherzinger commented Nov 6, 2023

marcoambrosini commented Nov 7, 2023

AndyScherzinger commented Nov 7, 2023

AndyScherzinger Nov 7, 2023

alperozturk96 Nov 7, 2023

JonasMayerDev commented Dec 6, 2023

JonasMayerDev left a comment

alperozturk96 commented Dec 6, 2023

JonasMayerDev commented Dec 6, 2023

alperozturk96 commented Dec 6, 2023

github-actions bot commented Dec 8, 2023

github-actions bot commented Dec 8, 2023

tobiasKaminsky commented Dec 8, 2023

Live Photo #12139

Live Photo #12139

Conversation

alperozturk96 commented Nov 6, 2023 • edited by AndyScherzinger Loading

AndyScherzinger commented Nov 6, 2023

alperozturk96 commented Nov 6, 2023

jancborchardt commented Nov 6, 2023

alperozturk96 commented Nov 6, 2023

jancborchardt commented Nov 6, 2023

AndyScherzinger Nov 6, 2023

Choose a reason for hiding this comment

AndyScherzinger Nov 6, 2023

Choose a reason for hiding this comment

AndyScherzinger commented Nov 6, 2023

AndyScherzinger commented Nov 6, 2023

jancborchardt commented Nov 6, 2023

AndyScherzinger commented Nov 6, 2023

marcoambrosini commented Nov 7, 2023

AndyScherzinger commented Nov 7, 2023

AndyScherzinger Nov 7, 2023

Choose a reason for hiding this comment

alperozturk96 Nov 7, 2023

Choose a reason for hiding this comment

JonasMayerDev commented Dec 6, 2023

JonasMayerDev left a comment

Choose a reason for hiding this comment

alperozturk96 commented Dec 6, 2023

JonasMayerDev commented Dec 6, 2023

alperozturk96 commented Dec 6, 2023

github-actions bot commented Dec 8, 2023

github-actions bot commented Dec 8, 2023

Codacy

Lint

SpotBugs

tobiasKaminsky commented Dec 8, 2023

alperozturk96 commented Nov 6, 2023 •

edited by AndyScherzinger

Loading