Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert FilePickerActivity to Kotlin #12168

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Convert FilePickerActivity to Kotlin #12168

merged 2 commits into from
Nov 20, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 15, 2023 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96 alperozturk96 changed the title Convert FilePickeActivity to Kotlin Convert FilePickerActivity to Kotlin Nov 15, 2023
@alperozturk96 @AndyScherzinger
Rename .java to .kt
3764136 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Convert to kt
1de7b5a 
Signed-off-by: alperozturk <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-FilePickerActivity-to-kt branch from 1aa81bf to 1de7b5a Compare November 20, 2023 16:55
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7070
Dodgy code363363
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total557557

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12168.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit ddad5eb into master Nov 20, 2023
18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-FilePickerActivity-to-kt branch November 20, 2023 20:11
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger