Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert CommunityActivity to Kotlin #12173

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Convert CommunityActivity to Kotlin #12173

merged 9 commits into from
Nov 20, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 15, 2023 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96
Rename .java to .kt
259872c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Convert to kt
230e81f 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Extract methods
2989439 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Use extensions
b773a14 
Signed-off-by: alperozturk <[email protected]>
@tobiasKaminsky
Copy link
Member

@alperozturk96 can you check the failing tests?

@alperozturk96
Fix spotless check
4d39b7d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix huawei flavour build
5709c20 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Add new line eof
df0d4f9 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix spotless
56e981a 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Suppress spotless check
04f1dcf 
Signed-off-by: alperozturk <[email protected]>
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12173.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7475
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7070
Dodgy code363363
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total557557

@AndyScherzinger AndyScherzinger merged commit e4b9be1 into master Nov 20, 2023
18 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-CommunityActivity-to-kt branch November 20, 2023 16:50
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @AndyScherzinger