Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Events to Kotlin #12184

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Convert Events to Kotlin #12184

merged 2 commits into from
Dec 5, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 17, 2023 •
edited
Loading

  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member

/rebase

@alperozturk96 @tobiasKaminsky
Rename .java to .kt
61e3d99 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @tobiasKaminsky
Convert to kt
4d8c97e 
Signed-off-by: alperozturk <[email protected]>
@nextcloud-command nextcloud-command force-pushed the refactor/convert-events-to-kt branch from d9960cd to 4d8c97e Compare December 1, 2023 09:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Codacy

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7070
Dodgy code360360
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total554554

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12184.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

JonasMayerDev
JonasMayerDev approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@JonasMayerDev JonasMayerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. App seems to still work fine.

@alperozturk96 alperozturk96 merged commit 646f0b4 into master Dec 5, 2023
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-events-to-kt branch December 5, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasMayerDev JonasMayerDev JonasMayerDev approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
4. to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @JonasMayerDev