Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom quota exceeded error message #12211

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

ZetaTom
Copy link
Collaborator

@ZetaTom ZetaTom commented Nov 29, 2023

When a user exceeds the allocated storage quota during an upload, an error message is displayed. Previously this message was not translated and always appeared in English: Insufficient Storage.

Steps to reproduce

  1. set up a user account on server with a low storage quota
  2. sign in on android app
  3. upload large file
  4. observe error message in notification

  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the fix/quota_exceeded_message branch from 45e2b04 to 0912782 Compare December 3, 2023 08:20
Copy link

github-actions bot commented Dec 3, 2023

Codacy

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7070
Dodgy code360360
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total554554

Copy link

github-actions bot commented Dec 3, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12211.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit 7232aab into master Dec 3, 2023
18 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/quota_exceeded_message branch December 3, 2023 12:30
Copy link

github-actions bot commented Apr 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants