Provide Better Feedback For Failed Uploads #12228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
JonasMayerDev
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Functionality of quick access to "FileUploadList" already exists. You should actually be able to simply click on the notification and be redirected. Maybe this is not working in Android 14? The implementation for this is in notifyUploadResult a view lines down from your reimplementation. Maybe get the original implementation to work?
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12228.apk |
JonasMayerDev
approved these changes
Dec 6, 2023
AndyScherzinger
approved these changes
Dec 6, 2023
delete-merged-branch
bot
deleted the
feature/better-feedback-for-failed-uploads
branch
AndyScherzinger
added a commit
that referenced
this pull request
Dec 6, 2023
Revert "Merge pull request #12228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upload failed user may want to navigate to Upload List so I added action for that into notification. Before this implementation user can just open conflict resolve dialog or dismiss notification
If user taps the notification goes to upload list
If user taps the resolve conflict FileResolveConflictDialog appears
Sometimes file cannot be found to solve conflict and nothing happens. I added snackbar message to provide better feedback
https://github.com/nextcloud/android/assets/67455295/2f36f36a-377e-4c77-8038-9a9415461462