Fix Crash DashboardWidgetService #12234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alperozturk96
commented
Dec 5, 2023
•
alperozturk96
commented
- Tests written, or not not needed
4 tasks
alperozturk96
commented
Dec 5, 2023
| @@ -166,55 +166,17 @@ class StackRemoteViewsFactory( | |||
| @Suppress("NestedBlockDepth", "TooGenericExceptionCaught") | |||
| private fun createItemView(position: Int): RemoteViews { | |||
| return RemoteViews(context.packageName, R.layout.widget_item).apply { | |||
| if (widgetItems.isEmpty()) { | |||
alperozturk96
commented
Dec 5, 2023
| if (widgetItem.iconUrl.isNotEmpty()) { | ||
| val glide: FutureTarget<Bitmap> |
There was a problem hiding this comment.
Extracted to separate functions for increase code readability
|
/rebase |
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
nextcloud-command
force-pushed
the
bugfix/fix-crash-DashboardWidgetService-IndexOutOfBoundsException
branch
from
88b4154 to
982bda6
Compare
Signed-off-by: alperozturk <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12234.apk |
|
/backport to stable-3.27 |
1 similar comment
|
/backport to stable-3.27 |
JonasMayerDev
approved these changes
Dec 6, 2023
delete-merged-branch
bot
deleted the
bugfix/fix-crash-DashboardWidgetService-IndexOutOfBoundsException
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.