Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.json:json to v20231013 #12470

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 30, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.json:json 20230618 -> 20231013 age adoption passing confidence

Release Notes

douglascrockford/JSON-java (org.json:json)

v20231013

Compare Source

Pull Request Description
#​793 Reverted #​761
#​792 update the docs for release 2023101
#​783 optLong vs getLong inconsistencies
#​782 Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows
#​779 add validity check for JSONObject constructors
#​778 Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows
#​776 Update [JUnit to version 4.13.2
#​774 Removing unneeded synchronization
#​773 Add optJSONArray method to JSONObject with a default value
#​772 Disallow nested objects and arrays as keys in objects
#​779 Unit test cleanup
#​769 Addressed Java 17 compile warnings
#​764 Update CodeQL action version
#​761 Add module-info
#​759 JSON parsing should detect embedded 
#​753 Updated new object methods
#​752 Fixes possible unit test bug when compiling/testing on Windows

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added 3. to review dependencies Pull requests that update a dependency file labels Jan 30, 2024
Copy link
Contributor Author

renovate bot commented Jan 30, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: app/build.gradle
Command failed: ./gradlew --console=plain --dependency-verification lenient -q --write-verification-metadata sha256,pgp help

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring project ':app'.
> SDK location not found. Define a valid SDK location with an ANDROID_HOME environment variable or by setting the sdk.dir path in your project's local properties file at '/tmp/renovate/repos/github/nextcloud/android/local.properties'.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring project ':app'.
> SDK location not found. Define a valid SDK location with an ANDROID_HOME environment variable or by setting the sdk.dir path in your project's local properties file at '/tmp/renovate/repos/github/nextcloud/android/local.properties'.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
==============================================================================

BUILD FAILED in 3m 3s

@renovate renovate bot force-pushed the renovate/org.json-json-20231013.x branch 2 times, most recently from dc9c0e2 to 3007d1c Compare February 1, 2024 10:12
@tobiasKaminsky tobiasKaminsky force-pushed the renovate/org.json-json-20231013.x branch from 3007d1c to e082e30 Compare February 1, 2024 12:08
@nextcloud nextcloud deleted a comment from github-actions bot Feb 1, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 1, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 1, 2024
@renovate renovate bot force-pushed the renovate/org.json-json-20231013.x branch 3 times, most recently from 055df82 to 422c467 Compare February 1, 2024 13:40
@AndyScherzinger AndyScherzinger force-pushed the renovate/org.json-json-20231013.x branch from 422c467 to 413c4c4 Compare February 4, 2024 20:30
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.29.0 milestone Feb 4, 2024
Signed-off-by: Andy Scherzinger <[email protected]>
Copy link
Contributor Author

renovate bot commented Feb 4, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link

github-actions bot commented Feb 4, 2024

Codacy

Lint

TypemasterPR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice6868
Correctness7373
Dodgy code359359
Experimental22
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5656
Security1818
Total591591

Copy link

github-actions bot commented Feb 4, 2024

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Merging #12470 (32f0e16) into master (5137c16) will increase coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12470      +/-   ##
============================================
+ Coverage     27.99%   28.17%   +0.17%     
- Complexity     3359     3378      +19     
============================================
  Files           622      622              
  Lines         45453    45453              
  Branches       6498     6498              
============================================
+ Hits          12724    12805      +81     
+ Misses        30593    30506      -87     
- Partials       2136     2142       +6     

see 18 files with indirect coverage changes

Copy link

github-actions bot commented Feb 5, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12470.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit d0d9995 into master Feb 5, 2024
21 of 22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the renovate/org.json-json-20231013.x branch February 5, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant